Skip to content

Fix correlation tool #6530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JohnMcPMS wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −2
Open

Fix correlation tool #6530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .../InstallAndCheckCorrelation/InstallAndCheckCorrelation/InstallAndCheckCorrelation.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,18 @@
<UseDebugLibraries>false</UseDebugLibraries>
<WholeProgramOptimization>true</WholeProgramOptimization>
</PropertyGroup>
<PropertyGroup Label="Configuration" Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<PlatformToolset>v143</PlatformToolset>
</PropertyGroup>
<PropertyGroup Label="Configuration" Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
<PlatformToolset>v143</PlatformToolset>
</PropertyGroup>
<PropertyGroup Label="Configuration" Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
<PlatformToolset>v143</PlatformToolset>
</PropertyGroup>
<PropertyGroup Label="Configuration" Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<PlatformToolset>v143</PlatformToolset>
</PropertyGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
<ImportGroup Label="ExtensionSettings">
</ImportGroup>
Expand Down
4 changes: 2 additions & 2 deletions tools/CorrelationTestbed/Test-CorrelationInSandbox.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,12 @@ $ Enable-WindowsOptionalFeature -Online -FeatureName 'Containers-DisposableClien
# Close Windows Sandbox

function Close-WindowsSandbox {
$sandbox = Get-Process 'WindowsSandboxClient' -ErrorAction SilentlyContinue
$sandbox = Get-Process 'WindowsSandboxRemoteSession' -ErrorAction SilentlyContinue
if ($sandbox)
{
Write-Host '--> Closing Windows Sandbox'

$sandboxServer = Get-Process 'WindowsSandbox' -ErrorAction SilentlyContinue
$sandboxServer = Get-Process 'WindowsSandboxServer' -ErrorAction SilentlyContinue
Comment on lines +110 to +115

@ranm-msft ranm-msft Sep 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we probe both process-name generations here? The newer Sandbox uses WindowsSandboxRemoteSession/WindowsSandboxServer, but the older implementation can still be active when the Store upgrade is unavailable or fails - and with -ErrorAction SilentlyContinue plus the if ($sandbox) gate, cleanup then becomes a silent no-op and sandboxes leak between runs. Passing both names to each Get-Process (e.g. Get-Process 'WindowsSandboxRemoteSession','WindowsSandboxClient' -ErrorAction SilentlyContinue) would keep both generations working.


$sandbox | Stop-Process
$sandbox | Wait-Process -Timeout 120
Expand Down
Loading