Repository navigation
Bump pyright to 1.1.414 and fix new type errors - #26272
Open
Austin Dickey (austin3dickey) wants to merge 1 commit into
Open
Austin Dickey (austin3dickey) wants to merge 1 commit into
Austin Dickey (austin3dickey) wants to merge 1 commit into
Conversation
Pyright 1.1.308 can't handle the ModelBase.__getattr__ fallback in django-stubs 6.1.1, which causes errors when type-checking on Python 3.12+. Bump to the latest release and fix the errors it reports.
Author
|
@microsoft-github-policy-service agree company="Posit" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26238. This PR changes the pyright version from 1.1.308 to 1.1.414.
Pyright 1.1.308 is over 3 years old at this point, and doesn't work with django-stubs 6.1.1 on Python 3.12 and later, so if you're running Pyright with Python 3.12 on this repo it reports 4 false errors in the
simple_djangotest fixture. Pyright 1.1.414 doesn't report these errors.The new version reports 9 other errors, too, which I fixed.