Repository navigation
Skip legacy capability inference for updated managers - #1955
Conversation
Skips method-based capability inference (legacy) when a manager advertises its capabilities.
There was a problem hiding this comment.
🟢 Approval recommended
The focused guards match the intended behavior, preserve legacy fallback, and have regression coverage for both manager types.
No open issues 🎉
What changed in this PR
This PR keeps explicit manager capability declarations separate from legacy method-based inference in the Python Environments extension.
Changes:
- Skip legacy inference for package and environment managers that advertise capabilities.
- Add regression tests for both manager types, verifying that available methods do not trigger legacy support detection.
| File | Description |
|---|---|
src/test/legacyCapabilities.unit.test.ts |
Adds regression coverage for managers with advertised capabilities. |
src/legacyCapabilities.ts |
Adds guards to bypass legacy inference when capabilities are declared. |
Review effort: Balanced
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Heejae Chang (heejaechang)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
78f5190
into
main
Skips method-based capability inference (legacy) when a manager advertises its capabilities.