Skip to content

Skip legacy capability inference for updated managers - #1955

Merged
Eduardo Villalpando Mello (edvilme) merged 2 commits into
mainfrom
api-legacy-capability
Oct 26, 2026
Merged

Eduardo Villalpando Mello (edvilme) merged 2 commits into
mainfrom
api-legacy-capability

Conversation

@edvilme

Copy link
Copy Markdown
Contributor

Skips method-based capability inference (legacy) when a manager advertises its capabilities.

Skips method-based capability inference (legacy) when a manager advertises its capabilities.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused guards match the intended behavior, preserve legacy fallback, and have regression coverage for both manager types.

No open issues 🎉

What changed in this PR

This PR keeps explicit manager capability declarations separate from legacy method-based inference in the Python Environments extension.

Changes:

  • Skip legacy inference for package and environment managers that advertise capabilities.
  • Add regression tests for both manager types, verifying that available methods do not trigger legacy support detection.
File Description
src/​test/​legacyCapabilities.unit.test.ts Adds regression coverage for managers with advertised capabilities.
src/​legacyCapabilities.ts Adds guards to bypass legacy inference when capabilities are declared.

Review effort: Balanced

@bschnurr

Copy link
Copy Markdown
Member

🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR.

@bschnurr

Copy link
Copy Markdown
Member

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported.

Test runs: none recorded.

@bschnurr Bill Schnurr (bschnurr) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@bschnurr Bill Schnurr (bschnurr) added the review-auto:approved Automated review: no blocking findings (approval posted). label Oct 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@edvilme
Eduardo Villalpando Mello (edvilme) merged commit 78f5190 into main Oct 26, 2026
108 of 113 checks passed
@edvilme
Eduardo Villalpando Mello (edvilme) deleted the api-legacy-capability branch October 26, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Code quality issues review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants