fix: fail gracefully on invalid pyproject.toml (Fixes #411) by StellaHuang95 · Pull Request #1942 · microsoft/vscode-python-environments

Stella Huang (StellaHuang95) · 2026-10-21T20:35:55Z

Summary

preserve pyproject.toml read and parse failures instead of treating malformed files as empty
validate the project, build-system, dependency container, and optional-extra fields consumed during installation
preflight only the exact dependency files selected by configurable creation while Quick Create validates relevant workspace dependencies
apply validation-independent preferred-root eligibility before duplicate selection so sibling worktrees cannot block or replace the owning project
preserve exact owner/ancestor precedence even when malformed metadata cannot yet emit install arguments
stop before environment creation on Open, Cancel, or dismissal; Continue Anyway uses only the filtered owning installables

Validation

npm run lint
npm run compile-tests
npm run compile
npm run unittest — 3,334 passing, 9 pending
focused pyproject/creation suite — 179 passing
VS Code smoke tests — 31 passing, 1 pending
VS Code E2E tests — 4 passing
disposable VS Code integration workflows — syntax errors, schema errors, invalid extras, sibling worktrees in both directions, no .venv on rejection, and valid creation/removal all passed
broad integration suite — 60 passing, 8 pending; the existing system-manager creation fixture timed out waiting for interactive Python installation
final Copilot review — approval recommended, no open issues

Fixes #411

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 34d0c32e-e8b7-4711-a695-1b6f6e56503f

Bill Schnurr (bschnurr) · 2026-10-21T20:42:31Z

🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR.

Copilot

🟡 Changes recommended

Validation-dependent root filtering can silently omit the owning project’s dependencies.

1 open issue

Apply preferred-root eligibility before duplicate grouping · New

What changed in this PR

Improves environment creation failure handling for invalid pyproject.toml files, addressing #411.

Changes:

Preserves read and parse failures and expands schema validation.
Validates selected dependencies before creation.
Adds coverage for cancellation, continuation, and sibling-worktree handling.

File	Description
src/test/managers/builtin/venvUtils.createWithProgress.unit.test.ts	Tests Quick Create validation outcomes.
src/test/managers/builtin/venvStepBasedFlow.unit.test.ts	Tests step-based creation preflight.
src/test/managers/builtin/pipUtils.unit.test.ts	Covers dependency selection and worktree filtering.
src/test/managers/builtin/helpers.validatePyproject.unit.test.ts	Tests schema validation and prompt actions.
src/managers/common/pickers.ts	Returns selected dependency file URIs.
src/managers/builtin/venvUtils.ts	Applies Quick Create preflight.
src/managers/builtin/venvStepBasedFlow.ts	Stops creation when preflight is rejected.
src/managers/builtin/pipUtils.ts	Implements validation and dependency filtering.

_{Review effort: Balanced}

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 34d0c32e-e8b7-4711-a695-1b6f6e56503f

Copilot

🟡 Changes recommended

Duplicate suppression can hide an invalid exact owner's validation error and install its ancestor without prompting.

1 open issue

Schema errors from invalid exact owners are hidden by ancestors · New

1 resolved since last review

Apply preferred-root eligibility before duplicate grouping

_{Review effort: Balanced}

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 34d0c32e-e8b7-4711-a695-1b6f6e56503f

Copilot

🟢 Approval recommended

No unresolved blocking issues remain in the validation, selection, or creation-flow changes.

No open issues 🎉

1 resolved since last review

Schema errors from invalid exact owners are hidden by ancestors

_{Review effort: Balanced}

Bill Schnurr (bschnurr) · 2026-10-21T21:21:41Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "7ee19b971263b9544c6b9ded818192331c44eabfa5148387f694bde1bb7b0ae7": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found

Test runs: none recorded.

Bill Schnurr (bschnurr)

Approved via Review Center.

Rich Chiodo (rchiodo)

Approved via Review Center.

Heejae Chang (heejaechang)

Approved via Review Center.

fix: fail gracefully on invalid pyproject.toml (Fixes microsoft#411)

2ea1882

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 34d0c32e-e8b7-4711-a695-1b6f6e56503f

Stella Huang (StellaHuang95) requested a balanced review from Copilot October 21, 2026 20:37

Copilot started reviewing on behalf of Stella Huang (StellaHuang95) October 21, 2026 20:38

View session

Stella Huang (StellaHuang95) added the bug Issue identified by VS Code Team member as probable bug label Oct 21, 2026

Copilot AI reviewed Oct 21, 2026

View reviewed changes

Comment thread src/managers/builtin/pipUtils.ts Outdated

fix: address pyproject review feedback (PR microsoft#1942)

c3151b5

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 34d0c32e-e8b7-4711-a695-1b6f6e56503f

Stella Huang (StellaHuang95) requested a balanced review from Copilot October 21, 2026 20:53

Copilot started reviewing on behalf of Stella Huang (StellaHuang95) October 21, 2026 20:54

View session

Copilot AI reviewed Oct 21, 2026

View reviewed changes

Comment thread src/managers/builtin/pipUtils.ts

fix: preserve exact pyproject ownership (PR microsoft#1942)

07095a7

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 34d0c32e-e8b7-4711-a695-1b6f6e56503f

Stella Huang (StellaHuang95) requested a balanced review from Copilot October 21, 2026 21:06

Copilot started reviewing on behalf of Stella Huang (StellaHuang95) October 21, 2026 21:06

View session

Copilot AI reviewed Oct 21, 2026

View reviewed changes

Bill Schnurr (bschnurr) approved these changes Oct 21, 2026

View reviewed changes

Bill Schnurr (bschnurr) added the review-auto:approved Automated review: no blocking findings (approval posted). label Oct 21, 2026

Rich Chiodo (rchiodo) approved these changes Oct 21, 2026

View reviewed changes

Heejae Chang (heejaechang) approved these changes Oct 21, 2026

View reviewed changes

Stella Huang (StellaHuang95) merged commit 897bc3b into microsoft:main Oct 21, 2026
58 checks passed

Navigation Menu

Repository navigation

fix: fail gracefully on invalid pyproject.toml (Fixes #411) - #1942

fix: fail gracefully on invalid pyproject.toml (Fixes #411)#1942
Stella Huang (StellaHuang95) merged 3 commits into
microsoft:mainfrom
StellaHuang95:stellahuang-microsoft-expert-tribble

Stella Huang (StellaHuang95) commented Oct 21, 2026 •

edited

Loading

Uh oh!

Bill Schnurr (bschnurr) commented Oct 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Bill Schnurr (bschnurr) commented Oct 21, 2026

Uh oh!

Bill Schnurr (bschnurr) left a comment

Uh oh!

Rich Chiodo (rchiodo) left a comment

Uh oh!

Heejae Chang (heejaechang) left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Stella Huang (StellaHuang95) commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Uh oh!

Bill Schnurr (bschnurr) commented Oct 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Bill Schnurr (bschnurr) commented Oct 21, 2026

Uh oh!

Bill Schnurr (bschnurr) left a comment

Choose a reason for hiding this comment

Uh oh!

Rich Chiodo (rchiodo) left a comment

Choose a reason for hiding this comment

Uh oh!

Heejae Chang (heejaechang) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Stella Huang (StellaHuang95) commented Oct 21, 2026 •

edited

Loading