Repository navigation
Pin GitHub Actions to full-length commit SHAs - #1910
Stella Huang (StellaHuang95) merged 6 commits into
Conversation
|
🔒 Automated review in progress — Heejae Chang (@heejaechang) is auto-reviewing this PR. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: Test runs: none recorded. |
Heejae Chang (heejaechang)
added
the
review-auto:changes-requested
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Could not download lodash.once@4.1.1 from the Microsoft package feed (ReadTimeout). Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
|
Result: 🔴 Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Details: Verification could not complete: timeout must be None or at least 2073600 seconds (24 days); shorter completion deadlines are unsupported. Test runs: none recorded. |
Explicitly select stable Rust for smoke, E2E and integration CI while retaining the full-length action SHA pins. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Stella Huang (StellaHuang95)
removed
the
review-auto:changes-requested
|
Fixed the CI blocker in 6d33058. The pinned The updated PR/CI Check run is green: all 52 jobs passed, including all smoke, E2E, integration, and multi-root matrix entries. One Windows/Python 3.12 integration environment-deletion timeout passed on a failed-job rerun without code or test changes. Both blocking review threads are resolved, and the stale changes-requested label has been cleared. Fresh approval is still required before merge. Run: https://github.com/microsoft/vscode-python-environments/actions/runs/40555160898 |
6a64564
into
microsoft:main
Summary
This PR pins GitHub Actions to full-length commit SHAs for improved security and reproducibility and adds a 7 day cooldown to Dependabot configuration for GitHub Actions. This work is described in more detail at https://aka.ms/action-pinning.
Why?
Pinning actions to commit SHAs prevents supply-chain attacks where a tag could be moved to point to malicious code. This is a recommended security best practice per the GitHub Actions security hardening guide.
This change mitigates the risk of tag retargeting to malicious code as seen in incidents like the tj-actions/changed-files action compromise or codfish/semantic-release-action compromise and improves the integrity and reproducibility of the CI/CD pipeline.
What changed?
Action pinning: Third-party action references in
.github/workflows/that used mutable tag-based references (e.g.,actions/checkout@v4) have been updated to full-length commit SHAs with a version comment (e.g.,actions/checkout@<sha> # v4) using the pinact tool. References that were already pinned to a SHA, or that used immutable release tags, were left unchanged.Dependabot configuration:
.github/dependabot.ymlhas been updated to ensure agithub-actionspackage-ecosystem section is present with acooldownconfiguration (default-days: 7). If the file did not exist, it was created. If agithub-actionssection already existed, only thecooldownblock was added or itsdefault-daysvalue was increased to 7 if it was lower. The 7-day cooldown provides a window for the community to detect and report compromised releases before they are automatically proposed as updates, reducing exposure to supply-chain attacks via newly published malicious versions.Is this safe to merge?
Yes. The pinned SHAs correspond to the same commits that the existing tags pointed to. No behavioral changes in action execution are introduced. You can verify the pinned SHA value using the GitHub REST API (e.g., the commit hash for
actions/checkout@v7can be found in theshaproperty in the JSON response forGET https://api.github.com/repos/actions/checkout/commits/v7).Additional Information
For more information, please see https://aka.ms/action-pinning