Open
Prevent review comment controller collisions across repositories#8863
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue adding comments on diff files in multiple PRs
Prevent review comment controller collisions across repositories
Jul 27, 2026
alexr00
approved these changes
Jul 29, 2026
alexr00
marked this pull request as ready for review
July 29, 2026 09:20
alexr00
approved these changes
Jul 29, 2026
alexr00
enabled auto-merge (squash)
July 29, 2026 09:20
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a multi-root workspace regression where review comment “+” controls could become unresponsive because multiple vscode.comments controllers were created with colliding IDs across different repositories.
Changes:
- Corrects
ReviewCommentControllerID construction to includeowner,repositoryName, and PRnumber(instead of repeatingownertwice). - Adds a regression test ensuring controllers for same-owner/same-number PRs in different repos produce distinct IDs.
Show a summary per file
| File | Description |
|---|---|
| src/view/reviewCommentController.ts | Fixes controller ID composition to prevent cross-repo collisions in multi-root workspaces. |
| src/test/view/reviewCommentController.test.ts | Adds coverage asserting controller IDs are correctly qualified and unique across repos. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In multi-root workspaces, checking out a second PR could make comment controls unresponsive for the first PR. Review controllers could share an ID because the repository segment incorrectly repeated the owner.
Controller identity
Regression coverage