Add Compose Pull support for updating project images - #592
Open
Miłosz Kordziński (milekv) wants to merge 3 commits into
Open
Add Compose Pull support for updating project images#592Miłosz Kordziński (milekv) wants to merge 3 commits into
Miłosz Kordziński (milekv) wants to merge 3 commits into
Conversation
Copilot started reviewing on behalf of
Miłosz Kordziński (milekv)
August 24, 2026 07:24
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Compose Pull support for updating project images across supported orchestrators from VS Code.
Changes:
- Adds typed, shared Compose pull command construction.
- Registers workspace, editor, Explorer, and Containers view commands.
- Adds localized contributions and unit tests.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Summary |
|---|---|
packages/vscode-container-client/src/test/clients/NerdctlComposeClient/NerdctlComposeClient.test.ts |
Tests Nerdctl Compose pull syntax. |
packages/vscode-container-client/src/test/clients/DockerComposeClient/DockerComposeClient.test.ts |
Tests service-targeted pull arguments. |
packages/vscode-container-client/src/contracts/ContainerOrchestratorClient.ts |
Defines the pull API; required contract changes may break existing third-party clients and older runtime implementations. Critical, 3 votes. |
packages/vscode-container-client/src/clients/DockerComposeClientBase/DockerComposeClientBase.ts |
Builds shared Compose pull arguments. |
extensions/vscode-containers/src/commands/registerCommands.ts |
Registers the new commands. |
extensions/vscode-containers/src/commands/containers/composeGroup.ts |
Adds pull support for running Compose groups. |
extensions/vscode-containers/src/commands/compose/compose.ts |
Implements workspace Compose Pull execution. |
extensions/vscode-containers/package.nls.json |
Adds localized command labels. |
extensions/vscode-containers/package.json |
Adds command and menu contributions. |
Suppressed comments (1)
packages/vscode-container-client/src/contracts/ContainerOrchestratorClient.ts:147
- The
servicesoption is not consumed by either new extension caller (composePullandcomposeGroupPullboth pass only common options); it exists only in the unit test and is described as being for future callers. This unnecessarily commits the public package contract to an option before a caller needs it. Please defer the option until service selection is implemented, or add the concrete caller in this change.
services?: Array<string>;
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
@microsoft-github-policy-service agree |
Comment on lines
+82
to
+85
| { | ||
| "command": "vscode-containers.containers.composeGroup.pull", | ||
| "when": "config.containers.containers.groupBy == 'Compose Project Name'" | ||
| }, |
Collaborator
There was a problem hiding this comment.
Compose groups represent a compose project that is already running. I am not sure that having a pull command for that is as useful as having the other one, which is for compose files. Matt Hernandez (@fiveisprime) any thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Compose Pull command so developers can update all images referenced by a Compose project without leaving VS Code.
The command is available from:
The orchestrator client exposes pull as an optional capability, keeping existing third-party clients compatible while sharing argument construction across Docker, Podman, nerdctl, and Finch. Unsupported clients receive a localized error.
Fixes #414.
Validation