Repository navigation
Fix OData V4 error serialization in generated Python models - #12069
Closed
Libba Lawrence (l0lawrence) wants to merge 1 commit into
Closed
Libba Lawrence (l0lawrence) wants to merge 1 commit into
Libba Lawrence (l0lawrence) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
Member
Author
|
feels like an azure-core change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Azure
ODataV4Formathas noas_dict()method. When a generated model materializes nested error details,model.as_dict()can retain those objects, so plainjson.dumps(model.as_dict())fails.What changed
Convert
ODataV4Formatto a wire-shaped dictionary at generatedas_dict(),SdkJSONEncoder, and_serializeboundaries. The Azure-only conversion handles recursive details and innererror while preserving omitted optional fields and nested nulls; the unbranded flavor remains unchanged. Added focused generated-template regression coverage and a fix changelog entry.Validation
test_odata_v4_serialization.py, with the mock-server parent fixture excluded).tscin this worktree. Repository formatting could not complete because the TypeSpec Prettier plugin'sdist/index.jshas not been built.