Repository navigation
Enable verbatimModuleSyntax in http-client-python emitter - #11517
Merged
Timothee Guerin (timotheeguerin) merged 1 commit intoJul 31, 2026
Merged
Timothee Guerin (timotheeguerin) merged 1 commit into
Timothee Guerin (timotheeguerin) merged 1 commit into
Conversation
Add verbatimModuleSyntax to the emitter tsconfig and convert type-only imports/exports to import type / export type.
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
Timothee Guerin (timotheeguerin)
marked this pull request as ready for review
July 31, 2026 17:25
Timothee Guerin (timotheeguerin)
requested review from
Chenxi Jiang (ChenxiJiang333),
catalinaperalta,
iscai-msft,
Kashif Khan (kashifkhan),
Libba Lawrence (l0lawrence),
Laurent Mazuel (lmazuel),
Mark Cowlishaw (markcowl),
Yuchao Yan (msyyc),
Chenjie Shi (tadelesh) and
Jeff Fisher (xirzec)
as code owners
July 31, 2026 17:25
iscai-msft
approved these changes
Jul 31, 2026
Timothee Guerin (timotheeguerin)
enabled auto-merge
July 31, 2026 18:07
Timothee Guerin (timotheeguerin)
added a commit
that referenced
this pull request
Aug 7, 2026
Completes the `verbatimModuleSyntax` rollout by turning the flag on centrally in `tsconfig.base.json`, so every package inherits it instead of opting in individually. Now that all workspace packages and the three standalone client emitters (C#/Java/Python) have been converted to type-only imports/exports, the per-package overrides are redundant. This PR: - Adds `"verbatimModuleSyntax": true` to `tsconfig.base.json`. - Removes the now-redundant per-package `verbatimModuleSyntax: true` overrides (48 tsconfigs). - Keeps the single intentional `verbatimModuleSyntax: false` in `packages/http-client-js/tsconfig.test.json` (generated e2e fixtures that aren't emitted with type-only imports). - Folds in the http-client-java emitter conversion so the base flip is self-contained and green regardless of merge order (also tracked standalone in #11516). No runtime behavior change — a dev-only TypeScript configuration change. Depends on the per-package rollout PRs having merged first (#11484, #11510, #11512, #11513, #11514, #11515, #11516, #11517).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the ongoing
verbatimModuleSyntaxrollout to the standalone Python client emitter (@typespec/http-client-python).verbatimModuleSyntaxmakes TypeScript emit imports/exports exactly as written, keeping type-only imports out of the runtime module graph. This is the same flag already enabled across most workspace packages; this PR turns it on for the Python emitter's TypeScript layer.What changed:
"verbatimModuleSyntax": truetoemitter/tsconfig.json.import type/export type(oxlint autofix, plus aexport typesplit for the options re-export inemitter/src/index.ts).No runtime behavior change — a dev-only TypeScript configuration/import-style change.