Skip to content

[python] compartmentalize generation-subdir - #10254

Merged
iscai-msft merged 3 commits into
microsoft:mainfrom
iscai-msft:python/generationSubdirContainment
May 1, 2026
Merged

iscai-msft merged 3 commits into
microsoft:mainfrom
iscai-msft:python/generationSubdirContainment

Conversation

@iscai-msft

Copy link
Copy Markdown
Member

right now, we're modifying files above the specified generation-subdir. My belief is that when a user specifies generation-subidr, we don't touch anything. We might want to touch the packaging files, that is debatable though.

@pkg-pr-new

pkg-pr-new Bot commented Apr 2, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/http-client-python@10254

commit: 3774150

@github-actions

github-actions Bot commented Apr 2, 2026 •

Copy link
Copy Markdown
Contributor

All changed packages have been documented.

  • ✅ @typespec/http-client-python
Show changes

@typespec/http-client-python - fix ✏️

Contain emitter changes when used with generation-subdir to solely within that subdirectory

@azure-sdk

Azure SDK Bot (azure-sdk) commented Apr 2, 2026 •

Copy link
Copy Markdown
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@msyyc
Yuchao Yan (msyyc) self-requested a review April 9, 2026 09:21
@iscai-msft
iscai-msft force-pushed the python/generationSubdirContainment branch from 9388122 to ba3b9a7 Compare April 20, 2026 18:45

@msyyc Yuchao Yan (msyyc) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems only some annotation update in this PR.

@iscai-msft
iscai-msft added this pull request to the merge queue May 1, 2026
Merged via the queue into microsoft:main with commit cb8f053 May 1, 2026
41 checks passed
@iscai-msft
iscai-msft deleted the python/generationSubdirContainment branch May 1, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emitter:client:python Issue for the Python client emitter: @typespec/http-client-python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants