Repository navigation
Closed
Labels
emitter:client:csharpIssue for the C# client emitter: @typespec/http-client-csharpIssue for the C# client emitter: @typespec/http-client-csharpfeatureNew feature or requestNew feature or request
Description
In our back compat support, we attempt to restore the previous contract's parameter name for service methods. It seems that are matching is too restrictive and several libraries are still having api compat issues do to name changes in parameters. We should relax the param lookup so these edge case scenarios are caught:
Sample library:
##[error]D:\a\_work\1\s\eng\Directory.Build.Common.targets(527,5): error : API compatibility errors between 'lib/netstandard2.0/Azure.ResourceManager.Redis.dll' (left) and 'lib/netstandard2.0/Azure.ResourceManager.Redis.dll' (right): [D:\a\_work\1\s\sdk\redis\Azure.ResourceManager.Redis\src\Azure.ResourceManager.Redis.csproj::TargetFramework=net10.0]
##[error]D:\a\_work\1\s\eng\Directory.Build.Common.targets(527,5): error CP0017: Parameter name on member 'Azure.ResourceManager.Redis.RedisResource.GetRedisPatchScheduleAsync(Azure.ResourceManager.Redis.Models.RedisPatchScheduleDefaultName, System.Threading.CancellationToken)' changed from 'defaultName' to 'default'. [D:\a\_work\1\s\sdk\redis\Azure.ResourceManager.Redis\src\Azure.ResourceManager.Redis.csproj::TargetFramework=net10.0]
##[error]D:\a\_work\1\s\eng\Directory.Build.Common.targets(527,5): error CP0017: Parameter name on member 'Azure.ResourceManager.Redis.RedisResource.GetRedisPatchSchedule(Azure.ResourceManager.Redis.Models.RedisPatchScheduleDefaultName, System.Threading.CancellationToken)' changed from 'defaultName' to 'default'. [D:\a\_work\1\s\sdk\redis\Azure.ResourceManager.Redis\src\Azure.ResourceManager.Redis.csproj::TargetFramework=net10.0]
##[error]D:\a\_work\1\s\eng\Directory.Build.Common.targets(527,5): error CP0017: Parameter name on member 'Azure.ResourceManager.Redis.RedisPatchScheduleCollection.CreateOrUpdateAsync(Azure.WaitUntil, Azure.ResourceManager.Redis.Models.RedisPatchScheduleDefaultName, Azure.ResourceManager.Redis.RedisPatchScheduleData, System.Threading.CancellationToken)' changed from 'defaultName' to 'default'. [D:\a\_work\1\s\sdk\redis\Azure.ResourceManager.Redis\src\Azure.ResourceManager.Redis.csproj::TargetFramework=net10.0]
##[error]D:\a\_work\1\s\eng\Directory.Build.Common.targets(527,5): error CP0017: Parameter name on member 'Azure.ResourceManager.Redis.RedisPatchScheduleCollection.CreateOrUpdate(Azure.WaitUntil, Azure.ResourceManager.Redis.Models.RedisPatchScheduleDefaultName, Azure.ResourceManager.Redis.RedisPatchScheduleData, System.Threading.CancellationToken)' changed from 'defaultName' to 'default'. [D:\a\_work\1\s\sdk\redis\Azure.ResourceManager.Redis\src\Azure.ResourceManager.Redis.csproj::TargetFramework=net10.0]
##[error]D:\a\_work\1\s\eng\Directory.Build.Common.targets(527,5): error CP0017: Parameter name on member 'Azure.ResourceManager.Redis.RedisPatchScheduleCollection.GetAsync(Azure.ResourceManager.Redis.Models.RedisPatchScheduleDefaultName, System.Threading.CancellationToken)' changed from 'defaultName' to 'default'. [D:\a\_work\1\s\sdk\redis\Azure.ResourceManager.Redis\src\Azure.ResourceManager.Redis.csproj::TargetFramework=net10.0]
##[error]D:\a\_work\1\s\eng\Directory.Build.Common.targets(527,5): error CP0017: Parameter name on member 'Azure.ResourceManager.Redis.RedisPatchScheduleCollection.Get(Azure.ResourceManager.Redis.Models.RedisPatchScheduleDefaultName, System.Threading.CancellationToken)' changed from 'defaultName' to 'default'. [D:\a\_work\1\s\sdk\redis\Azure.ResourceManager.Redis\src\Azure.ResourceManager.Redis.csproj::TargetFramework=net10.0]
##[error]D:\a\_work\1\s\eng\Directory.Build.Common.targets(527,5): error CP0017: Parameter name on member 'Azure.ResourceManager.Redis.RedisPatchScheduleCollection.ExistsAsync(Azure.ResourceManager.Redis.Models.RedisPatchScheduleDefaultName, System.Threading.CancellationToken)' changed from 'defaultName' to 'default'. [D:\a\_work\1\s\sdk\redis\Azure.ResourceManager.Redis\src\Azure.ResourceManager.Redis.csproj::TargetFramework=net10.0]
##[error]D:\a\_work\1\s\eng\Directory.Build.Common.targets(527,5): error CP0017: Parameter name on member 'Azure.ResourceManager.Redis.RedisPatchScheduleCollection.Exists(Azure.ResourceManager.Redis.Models.RedisPatchScheduleDefaultName, System.Threading.CancellationToken)' changed from 'defaultName' to 'default'. [D:\a\_work\1\s\sdk\redis\Azure.ResourceManager.Redis\src\Azure.ResourceManager.Redis.csproj::TargetFramework=net10.0]
##[error]D:\a\_work\1\s\eng\Directory.Build.Common.targets(527,5): error CP0017: Parameter name on member 'Azure.ResourceManager.Redis.RedisPatchScheduleCollection.GetIfExistsAsync(Azure.ResourceManager.Redis.Models.RedisPatchScheduleDefaultName, System.Threading.CancellationToken)' changed from 'defaultName' to 'default'. [D:\a\_work\1\s\sdk\redis\Azure.ResourceManager.Redis\src\Azure.ResourceManager.Redis.csproj::TargetFramework=net10.0]
##[error]D:\a\_work\1\s\eng\Directory.Build.Common.targets(527,5): error CP0017: Parameter name on member 'Azure.ResourceManager.Redis.RedisPatchScheduleCollection.GetIfExists(Azure.ResourceManager.Redis.Models.RedisPatchScheduleDefaultName, System.Threading.CancellationToken)' changed from 'defaultName' to 'default'. [D:\a\_work\1\s\sdk\redis\Azure.ResourceManager.Redis\src\Azure.ResourceManager.Redis.csproj::TargetFramework=net10.0]
##[error]D:\a\_work\1\s\eng\Directory.Build.Common.targets(527,5): error : API breaking changes found. If those are intentional, the APICompat suppression file can be updated by rebuilding with '/p:ApiCompatGenerateSuppressionFile=true' [D:\a\_work\1\s\sdk\redis\Azure.ResourceManager.Redis\src\Azure.ResourceManager.Redis.csproj::TargetFramework=net10.0]
Reacted by github-actions
Metadata
Metadata
Assignees
Labels
emitter:client:csharpIssue for the C# client emitter: @typespec/http-client-csharpIssue for the C# client emitter: @typespec/http-client-csharpfeatureNew feature or requestNew feature or request
Activity
github-actions commentedon Jul 30, 2026
🎯 Issue Triage
The C# client emitter's back-compat parameter name restoration logic is too restrictive, missing edge cases where parameter names changed (e.g.,
defaultName→default), resulting inCP0017API compatibility errors in generated Azure SDK libraries.Category: Feature Request
Area:
emitter:client:csharp🔍 Analysis
defaultNamerenamed todefault(a reserved keyword in C#) across multiple methods inAzure.ResourceManager.Redis(GetRedisPatchSchedule,CreateOrUpdate,Get,Exists,GetIfExistsvariants).ModelFactory; the two issues share the back-compat overload generation area but describe different failure modes.📝 Suggested next steps
defaultName→defaultrename scenario and similar edge casesAzure.ResourceManager.Redisas a regression testfix: relax back compat param name matching (microsoft#11491)