Skip to content

Python: Handle empty chat message function results #14375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alperen (lprnmns) wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −7
Open

Python: Handle empty chat message function results #14375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions python/semantic_kernel/contents/function_result_content.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

from semantic_kernel.const import DEFAULT_FULLY_QUALIFIED_NAME_SEPARATOR
from semantic_kernel.contents.const import FUNCTION_RESULT_CONTENT_TAG, TEXT_CONTENT_TAG, ContentTypes
from semantic_kernel.contents.image_content import ImageContent
from semantic_kernel.contents.kernel_content import KernelContent
from semantic_kernel.contents.text_content import TextContent
from semantic_kernel.contents.utils.author_role import AuthorRole
Expand Down Expand Up @@ -138,12 +137,6 @@ def from_function_call_content_and_result(
if isinstance(result, TextContent):
res = result.text
elif isinstance(result, ChatMessageContent):
if isinstance(result.items[0], TextContent):
res = result.items[0].text
elif isinstance(result.items[0], ImageContent):
res = result.items[0].data_uri
elif isinstance(result.items[0], FunctionResultContent):
res = result.items[0].result
res = str(result)
else:
Comment on lines 139 to 141
res = result
Expand Down
10 changes: 10 additions & 0 deletions python/tests/unit/contents/test_function_result_content.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,16 @@ def test_from_fcc_and_result(result: any):
assert frc.metadata == {"test": "test", "test2": "test2"}


def test_from_fcc_and_empty_chat_message_result():
fcc = FunctionCallContent(id="test", name="test-function")
result = ChatMessageContent(role="assistant")

frc = FunctionResultContent.from_function_call_content_and_result(fcc, result)

assert frc.result == ""
assert frc.inner_content is result


def test_to_cmc():
frc = FunctionResultContent(id="test", name="test-function", result="test-result")
cmc = frc.to_chat_message_content()
Expand Down
Loading