fix: follow Registry API Link pagination when listing tags - #84
Closed
Abhinesh Jha (Abhineshhh) wants to merge 1 commit into
Closed
fix: follow Registry API Link pagination when listing tags#84Abhinesh Jha (Abhineshhh) wants to merge 1 commit into
Abhinesh Jha (Abhineshhh) wants to merge 1 commit into
Conversation
GetTags issued a single tags/list request and ignored the Link rel=next header, so large repositories could silently drop tags before filtering and --max-tags selection. Page with n=100 and follow next links until exhausted; add unit tests with a multi-page httptest server. Fixes microsoft#76
Abhinesh Jha (Abhineshhh)
requested review from
Dariusz Porowski (DariuszPorowski) and
Mani Bindra (maniSbindra)
as code owners
July 16, 2026 19:58
3 tasks
Contributor
Author
|
Closing in favor of a consolidated stack to avoid multi-PR conflicts on the same files. Superseded by consolidated registry stack (pagination is included there). Please review the replacement PR linked above (Trivy stack or registry stack). |
Contributor
Author
|
Replacement: #88 (registry stack). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GetTagsperformed a singletags/listrequest and ignored theLink: rel="next"header, so large repositories could silently drop tags before filtering and--max-tags.Related Issue
Fixes #76
Changes
n=100and follow next links until exhaustedChecklist
task lintpasses locallytask testpasses locally