Preserve literal rows in defined table types - #411
Merged
Alex Vallone (amv146) merged 6 commits intoAug 21, 2026
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9839e176-efce-4a70-811b-7e2668cdb7f3
This was referenced Aug 18, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9839e176-efce-4a70-811b-7e2668cdb7f3
JordanBoltonMN
requested changes
Aug 19, 2026
| FieldSpecificationList<OrderedFields> & { | ||
| readonly kind: TypeKind.Table; | ||
| readonly extendedKind: ExtendedTypeKind.DefinedTable; | ||
| readonly rows?: ReadonlyArray<DefinedRecord>; |
Contributor
There was a problem hiding this comment.
- make it not optional
- simplify to
ReadonlyArray<UnorderedFields>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 946bd35e-0c84-49f0-90ff-a15d522d34f8
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 946bd35e-0c84-49f0-90ff-a15d522d34f8
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 946bd35e-0c84-49f0-90ff-a15d522d34f8
JordanBoltonMN
approved these changes
Aug 20, 2026
JordanBoltonMN
approved these changes
Aug 21, 2026
Alex Vallone (amv146)
deleted the
alexvallone/table-literal-inference-0.18.5
branch
August 21, 2026 17:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefinedTableTypeUtils.definedTableto receive retained rowsRelated stack
Validation
npm run buildnpm test(680 passing, 1 pending)