feat(network): support multiple httpCredentials for different origins#41822
Open
Gby56 wants to merge 1 commit into
Open
feat(network): support multiple httpCredentials for different origins#41822Gby56 wants to merge 1 commit into
Gby56 wants to merge 1 commit into
Conversation
Allow httpCredentials to be a single object or an array of origin-scoped credentials. Chromium, BiDi, APIRequest, and Firefox (juggler) pick by origin; WebKit rejects multi-entry arrays. Fixes: microsoft#22013 Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
@Gby56 Could you please comment on the issue and explain your usecase? Although this seems theoretically useful, in practice we haven't seen any real scenarios that would justify the complexity (this PR, for example, touches over 700 lines in 39 files). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
httpCredentialsto be a single object or an array of origin-scoped credentials (HttpCredentials | HttpCredentials[])Fixes #22013
Made with Cursor