Normalize directional network input directly - #1383
Open
Gudge (MGudgin) wants to merge 1 commit into
Open
Gudge (MGudgin) wants to merge 1 commit into
Gudge (MGudgin) wants to merge 1 commit into
Conversation
This PR removes legacy network-format selection after the pre-v0.9 contracts are retired. Shared normalization applies directional policy and proxy sections without changing runtime compatibility or policy identity. Details * Remove unreachable legacy parsing and validation paths. * Keep directional defaults and state-aware network presence behavior. * Test exact-contract rejection of legacy fields and update versioning docs. Tests * cargo fmt --manifest-path .\src\Cargo.toml --all -- --check: passed. * cargo test --manifest-path .\src\Cargo.toml -p wxc_common -p bwrap_common -p nanvix_runner --quiet: passed. * cargo check --manifest-path .\src\Cargo.toml --workspace --all-targets --quiet: passed. * cargo clippy --manifest-path .\src\Cargo.toml -p wxc_common --all-targets -- -D warnings: passed. * Workspace Clippy fails on the unchanged process_container_common unnecessary_sort_by lint in appcontainer_runner.rs:117. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ff6d3538-5272-492f-aba0-5f7ef9feda2f Generated-with: gpt-6-sol
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes obsolete legacy network-format selection after #1382 retires
pre-v0.9 contracts. Shared normalization now applies the directional network
sections directly, without changing runtime compatibility or policy identity.
Details
Test
cargo fmt --manifest-path .\src\Cargo.toml --all -- --check— passed.cargo test --manifest-path .\src\Cargo.toml -p wxc_common -p bwrap_common -p nanvix_runner --quiet— passed (922 shared-crate tests plus backend and integration groups).cargo check --manifest-path .\src\Cargo.toml --workspace --all-targets --quiet— passed.cargo clippy --manifest-path .\src\Cargo.toml -p wxc_common --all-targets -- -D warnings— passed.cargo clippy --manifest-path .\src\Cargo.toml --workspace --all-targets -- -D warnings— failed on pre-existingclippy::unnecessary_sort_byinsrc/backends/process_container/common/src/appcontainer_runner.rs:117; unchanged by this PR.Microsoft Reviewers: Open in CodeFlow