[IsolationSession] Select the C# end-to-end test classes in any namespace - #1371
Merged
Branden Bonaby (bbonaby) merged 1 commit intoOct 2, 2026
Merged
Conversation
The scheduled isolation-session jobs selected the C# end-to-end classes by fully qualified name. #1355 moved both into Microsoft.Mxc.Sdk.Tests.V1, so the filters matched nothing and the C# suite executed no tests. The filters now match the class names in any namespace, and the suite fails when either class executes no tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 74255d4c-9d4f-4f2f-a9cc-e6d3ecd37780
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Branden Bonaby (bbonaby)
approved these changes
Oct 2, 2026
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: None
What changed in this PR
Fixes isolation-session scheduled jobs by making C# end-to-end test selection resilient to namespace changes and by failing the job if either required E2E test class runs zero tests.
Changes:
- Update C# xUnit runner filters to select the target test classes in any namespace (
-class *.<name>). - Add XML-based validation to ensure each required class executed at least one passing/failing test, and report failures clearly.
| File | Description |
|---|---|
| scripts/ci/run_backend_validation_tests.ps1 | Updates isolation-session C# test filtering and adds per-class “no tests executed” validation via xUnit result XML. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Branden Bonaby (bbonaby)
deleted the
user/adibpa/copilot-iso-csharp-class-filter
branch
October 2, 2026 18:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
The scheduled isolation-session jobs selected the C# end-to-end tests by fully qualified class name. #1355 moved both classes into the
Microsoft.Mxc.Sdk.Tests.V1namespace, so the filters matched nothing, the C# suite reported that it executed no tests, and all four isolation-session jobs failed.The suite now selects
MxcSandboxIsolationSessionE2ETestsandMxcLifecycleE2ETestsin any namespace (-class *.<name>), and fails when either class executes no tests.🔗 References
Follows #1355. Failing nightly: https://github.com/microsoft/mxc/actions/runs/36982494352
🔍 Validation
MXC_ISO_TESTS_REQUIRED=1: the old filters ran no tests; the new filters ran 9, all passed.windows-prerelease-isolation-sessionandwindows-prerelease-26h1, x64 and arm64), each running 9 C# tests: https://github.com/microsoft/mxc/actions/runs/37020708486✅ Checklist
📋 Issue Type
Microsoft Reviewers: Open in CodeFlow