Skip to content

[IsolationSession] Select the C# end-to-end test classes in any namespace - #1371

Merged
Branden Bonaby (bbonaby) merged 1 commit into
mainfrom
user/adibpa/copilot-iso-csharp-class-filter
Oct 2, 2026
Merged

Branden Bonaby (bbonaby) merged 1 commit into
mainfrom
user/adibpa/copilot-iso-csharp-class-filter

Conversation

@adpa-ms

@adpa-ms adpa-ms commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

📖 Description

The scheduled isolation-session jobs selected the C# end-to-end tests by fully qualified class name. #1355 moved both classes into the Microsoft.Mxc.Sdk.Tests.V1 namespace, so the filters matched nothing, the C# suite reported that it executed no tests, and all four isolation-session jobs failed.

The suite now selects MxcSandboxIsolationSessionE2ETests and MxcLifecycleE2ETests in any namespace (-class *.<name>), and fails when either class executes no tests.

🔗 References

Follows #1355. Failing nightly: https://github.com/microsoft/mxc/actions/runs/36982494352

🔍 Validation

  • With the failing nightly's own test binary on an x64 test machine with the IsolationSession service and MXC_ISO_TESTS_REQUIRED=1: the old filters ran no tests; the new filters ran 9, all passed.
  • The new check, given those runs' result XML: it passes the 9-test run, fails the empty run naming both classes, and fails a copy with one class's results removed, which the previous check passed.
  • The Scheduled Validation Tests workflow on this branch, limited to the isolation-session entries: all four jobs passed (windows-prerelease-isolation-session and windows-prerelease-26h1, x64 and arm64), each running 9 C# tests: https://github.com/microsoft/mxc/actions/runs/37020708486

✅ Checklist

📋 Issue Type

  • Bug fix
Microsoft Reviewers: Open in CodeFlow

The scheduled isolation-session jobs selected the C# end-to-end classes by
fully qualified name. #1355 moved both into Microsoft.Mxc.Sdk.Tests.V1, so the
filters matched nothing and the C# suite executed no tests. The filters now
match the class names in any namespace, and the suite fails when either class
executes no tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 74255d4c-9d4f-4f2f-a9cc-e6d3ecd37780
Copilot AI balanced review requested due to automatic review settings October 2, 2026 16:01
@adpa-ms
adpa-ms requested a review from a team as a code owner October 2, 2026 16:01
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: None

What changed in this PR

Fixes isolation-session scheduled jobs by making C# end-to-end test selection resilient to namespace changes and by failing the job if either required E2E test class runs zero tests.

Changes:

  • Update C# xUnit runner filters to select the target test classes in any namespace (-class *.<name>).
  • Add XML-based validation to ensure each required class executed at least one passing/failing test, and report failures clearly.
File Description
scripts/​ci/​run_backend_validation_tests.ps1 Updates isolation-session C# test filtering and adds per-class “no tests executed” validation via xUnit result XML.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@bbonaby
Branden Bonaby (bbonaby) merged commit 298bb39 into main Oct 2, 2026
31 checks passed
@bbonaby
Branden Bonaby (bbonaby) deleted the user/adibpa/copilot-iso-csharp-class-filter branch October 2, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants