Move the SDK authoring types into mxc-sdk by MGudgin · Pull Request #1353 · microsoft/mxc

Gudge (MGudgin) · 2026-09-30T16:57:51Z

This PR moves the Rust SDK's v1 policy, containment, request,
and typed lifecycle authoring types into mxc-sdk. The engine now accepts a
normalized ExecutionRequest from either the SDK builder or the exact JSON
parser and keeps backend dispatch, host probing, telemetry, and execution in
one place.

Details

Move policy, exact v1 builder, SDK v1 goldens, backend config types, and
typed lifecycle SDK models into mxc-sdk under the public mxc_sdk::v1 paths.
Replace mxc_engine::spawn(SandboxRequest) with
mxc_engine::spawn_execution_request(&ExecutionRequest).
Keep root mxc_sdk raw JSON, discovery, telemetry, Sandbox, Output, and
WaitOutcome APIs stable while v1::spawn_sandbox forwards request.inner to
the engine.
Add direct mxc_config_contract and serde dependencies to mxc-sdk and remove
non-test contract dependency from mxc_engine.
Rewrite engine tests to use ExecutionRequest or SdkStateAwareInput directly
and move SDK-builder validation tests with the moved SDK code.

Tests

Baseline Rust test inventory: mxc_engine 139, mxc-sdk 60, mxc_ffi 84;
total 283. After move: mxc_engine 90, mxc-sdk 109, mxc_ffi 84; total 283.
cargo fmt --all -- --check; cargo check --workspace --all-targets
--all-features; cargo clippy --workspace --all-targets --all-features --
-D warnings; cargo test -p mxc_engine --all-features; cargo test -p
mxc-sdk --all-features; cargo test -p mxc_ffi --all-features; cargo test
-p wxc --all-features; RUSTDOCFLAGS=-D warnings cargo doc -p mxc-sdk -p
mxc_ffi --no-deps --all-features.
sdk/node: npm run build; npm test; npm run typecheck.
sdk/dotnet: dotnet test --solution Microsoft.Mxc.Sdk.slnx.
node scripts/check-dotnet-api-parity.js; node
scripts/check-dotnet-bindings-codegen.js; node
scripts/versioning/check-contract-codegen.js; node
scripts/versioning/validate-configs.js; node
scripts/versioning/check-tests-present.js.
git diff --check.

Microsoft Reviewers: Open in CodeFlow

azure-pipelines · 2026-09-30T16:58:01Z

Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run.

This PR adds a handoff for the v1 SDK and JSON-only FFI ingress stack and updates the ingress plan to match what was built. It records the pull requests, branches, worktrees, and backups, the design decisions and their reasons, review status, open items, and working notes for a new session. Details * Add docs/version-aware-stack-session-handoff-2026-09-30.md covering #1271, #1348, and #1349-#1353, the backend-based experimental opt-in, JSON-only ingress, V1 namespaces and MxcPlatform, the pinned SDK target, Node export conditions, shared goldens, and E0. * Mark the plan adopted, replace the planned branch table with the opened pull requests, record the unified experimental check, the serde removal, the V1 writer location, and E0, and add the namespace, goldens, and E0 decisions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 33217f7b-dc7d-4da0-af5f-018fef64013c Generated-with: claude-opus-5.5

Copilot

Copilot review overview

🟡 Changes recommended

The new engine metadata type is compiled out while still referenced unconditionally on Linux and macOS.

Review effort: Balanced
Findings: 1

Open (1)

Cross-platform builds fail because EngineProvisionMetadata is Windows-gated · New

What changed in this PR

Moves Rust v1 authoring and lifecycle types from mxc_engine into the public mxc-sdk facade while retaining execution and backend dispatch in the engine.

Changes:

Relocates policy, backend configuration, lifecycle models, and golden tests into mxc-sdk.
Changes engine APIs to consume normalized execution inputs.
Updates dependencies and documentation for the new ownership boundary.

File	Description
`tests/policy/README.md`	Updates golden-test paths and commands.
`src/mxc_telemetry/src/lib.rs`	Updates engine API references.
`src/core/wxc_common/src/telemetry/mod.rs`	Updates streaming API documentation.
`src/core/wxc_common/src/sdk_input.rs`	Documents SDK ownership.
`src/core/mxc-sdk/src/state_aware_sdk.rs`	Owns lifecycle models and engine result conversion.
`src/core/mxc-sdk/src/sandbox.rs`	Converts typed lifecycle requests before engine dispatch.
`src/core/mxc-sdk/src/policy/sdk_v1_goldens.rs`	Moves SDK golden validation.
`src/core/mxc-sdk/src/policy/network.rs`	Adds public network authoring types.
`src/core/mxc-sdk/src/policy/exact/v1_0.rs`	Builds exact v1 contracts.
`src/core/mxc-sdk/src/policy/exact/mod.rs`	Normalizes SDK policy requests.
`src/core/mxc-sdk/src/policy.rs`	Updates public request documentation.
`src/core/mxc-sdk/src/lib.rs`	Exposes the relocated v1 API.
`src/core/mxc-sdk/src/configs/seatbelt.rs`	Adds Seatbelt authoring configuration.
`src/core/mxc-sdk/src/configs/process_container.rs`	Adds ProcessContainer configuration and tests.
`src/core/mxc-sdk/src/configs/lxc.rs`	Adds LXC authoring configuration.
`src/core/mxc-sdk/src/configs.rs`	Re-exports backend configurations.
`src/core/mxc-sdk/Cargo.toml`	Adds contract and test dependencies.
`src/core/mxc_engine/src/state_aware.rs`	Replaces SDK models with normalized engine DTOs.
`src/core/mxc_engine/src/run.rs`	Uses normalized requests in attribution tests.
`src/core/mxc_engine/src/lib.rs`	Exposes normalized execution entry points.
`src/core/mxc_engine/src/error.rs`	Updates API documentation.
`src/core/mxc_engine/src/dispatch.rs`	Rewrites tests around normalized requests.
`src/core/mxc_engine/Cargo.toml`	Removes the runtime contract dependency.
`src/Cargo.lock`	Records dependency relocation.
`src/backends/bubblewrap/common/src/bwrap_runner.rs`	Updates engine API references.
`src/backends/bubblewrap/common/src/bwrap_command.rs`	Updates SDK builder references.
`docs/authoring-a-new-feature.md`	Points feature authors to the SDK builder.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

Copilot review overview

🟡 Changes recommended

The new engine metadata type is Windows-gated despite unconditional cross-platform references, breaking Linux and macOS builds.

Review effort: Balanced
Findings: 1 · 1 · 1

Open (3)

Cross-platform builds fail because EngineProvisionMetadata is Windows-gated
Restore SDK mapper and parity tests · New
Correct build_request API and contract reference · New

Copilot

Copilot review overview

🟡 Changes recommended

Contributor and package documentation currently reference a nonexistent builder path and contradict the new ownership model.

Review effort: Balanced
Findings: 1 · 3

Open (4)

Restore SDK mapper and parity tests
Document or add the missing v1.1 development-contract builder path · New
Update README to reflect moved config-builder ownership · New
Correct build_request API and contract reference

Resolved since last review (1)

Cross-platform builds fail because EngineProvisionMetadata is Windows-gated

This PR moves the Rust SDK's v1 policy, containment, request, and typed lifecycle authoring types into mxc-sdk. The engine accepts normalized ExecutionRequest input from the SDK builder or exact JSON parser and keeps backend dispatch, host probing, telemetry, and execution in one place. Details * Move V1 policy and config types, the exact 1.0.0 builder, conformance tests, and typed lifecycle requests into mxc-sdk. * Keep backend execution in mxc_engine; typed spawn and Windows request probe adapt SDK-owned requests to engine-owned ExecutionRequest entry points. * Preserve raw JSON, discovery, telemetry, and streaming handle APIs. * Correct SDK ownership, development-contract guidance, and Bubblewrap defense-in-depth documentation. Tests * cargo fmt --all -- --check; cargo check --workspace --all-targets --all-features --quiet: passed. * cargo clippy --workspace --all-targets --all-features --quiet -- -D warnings: passed. * cargo test -p mxc-sdk -p mxc_engine -p mxc_ffi -p wxc_common --all-features --quiet: passed. * cargo check -p mxc-sdk -p mxc_engine -p mxc_ffi --all-targets for Linux and macOS targets: passed. * RUSTDOCFLAGS=-D warnings cargo doc -p mxc-sdk -p mxc_ffi --all-features --no-deps --quiet: passed. * Exact contract/codegen, 417 config fixtures, version, binding, API parity, and test-presence gates passed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 33217f7b-dc7d-4da0-af5f-018fef64013c Generated-with: gpt-5.5 Copilot-Session: 30c4f940-9c8e-4d3e-89ff-b1776045bb1c Generated-with: gpt-6-sol

Copilot

Copilot review overview

🟡 Changes recommended

Stale architecture documentation and ineffective compile-fail examples should be corrected before approval.

Review effort: Balanced
Findings: 1

Open (1)

Update architecture guide to assign policy construction to mxc-sdk · New

Resolved since last review (4)

Restore SDK mapper and parity tests
Update README to reflect moved config-builder ownership
Document or add the missing v1.1 development-contract builder path
Correct build_request API and contract reference

+//! host probing, and execution live in the internal `mxc_engine` crate;
+//! `mxc-sdk` owns the public policy/config authoring layer and wraps the
+//! engine's streaming handle in [`Sandbox`].


This PR fixes the Linux x64 and arm64 dispatch gate after the exact-JSON FFI migration renamed its LXC routing test. The workflow still selected the removed test name, so the zero-test guard failed after #1353 merged. The rename originated in #1352. Details * Select the existing mxc_spawn_json LXC routing test in the Linux gate. * Document the pinned dispatch coverage and its zero-test failure behavior. Tests * Ubuntu 24.04 WSL: replayed the old selector and reproduced the zero-test guard failure; the corrected workflow step passed all four pinned checks (5 discovery, 1 dispatch, 1 FFI routing, and 10 SDK-helper tests). * cargo test --locked --release --target x86_64-unknown-linux-gnu -p mxc_ffi --test ffi: passed all 11 tests. * git diff --check: passed. Native ARM64 was not verified locally. Generated-with: gpt-6.1-sol Co-authored-by: Gudge <gudge@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0c3a4f93-e784-41c7-9286-bdcefcb80465

This PR adds a handoff for the v1 SDK and JSON-only FFI ingress stack and updates the ingress plan to match what was built. It records the pull requests, branches, worktrees, and backups, the design decisions and their reasons, review status, open items, and working notes for a new session. Details * Add docs/version-aware-stack-session-handoff-2026-09-30.md covering #1271, #1348, and #1349-#1353, the backend-based experimental opt-in, JSON-only ingress, V1 namespaces and MxcPlatform, the pinned SDK target, Node export conditions, shared goldens, and E0. * Mark the plan adopted, replace the planned branch table with the opened pull requests, record the unified experimental check, the serde removal, the V1 writer location, and E0, and add the namespace, goldens, and E0 decisions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 33217f7b-dc7d-4da0-af5f-018fef64013c Generated-with: claude-opus-5.5

Gudge (MGudgin) force-pushed the user/gudge/move-sdk-policy-types branch from 91b389c to efc776c Compare September 30, 2026 17:18

Gudge (MGudgin) force-pushed the user/gudge/move-sdk-policy-types branch from efc776c to e44c918 Compare September 30, 2026 17:27

Gudge (MGudgin) force-pushed the user/gudge/move-sdk-policy-types branch from e44c918 to c0f2a80 Compare September 30, 2026 17:32

Gudge (MGudgin) force-pushed the user/gudge/move-sdk-policy-types branch from c0f2a80 to ec05b94 Compare September 30, 2026 20:29

Gudge (MGudgin) force-pushed the user/gudge/move-sdk-policy-types branch from ec05b94 to fae3cba Compare September 30, 2026 20:31

Gudge (MGudgin) added this pull request to stack #1356 September 30, 2026 21:26

Gudge (MGudgin) marked this pull request as ready for review September 30, 2026 21:27

Gudge (MGudgin) requested a review from a team as a code owner September 30, 2026 21:27

Copilot AI balanced review requested due to automatic review settings September 30, 2026 21:27

Copilot started reviewing on behalf of Gudge (MGudgin) September 30, 2026 21:28 View session

Gudge (MGudgin) requested a review from a team September 30, 2026 21:30

Gudge (MGudgin) force-pushed the user/gudge/move-sdk-policy-types branch from fae3cba to 3ac7782 Compare September 30, 2026 21:30

Copilot AI reviewed Sep 30, 2026

View reviewed changes

Comment thread src/core/mxc_engine/src/state_aware.rs Outdated

Copilot AI balanced review requested due to automatic review settings September 30, 2026 21:31

Copilot started reviewing on behalf of Gudge (MGudgin) September 30, 2026 21:31 View session

Copilot AI reviewed Sep 30, 2026

View reviewed changes

Comment thread src/core/mxc_engine/src/state_aware.rs

Comment thread src/backends/bubblewrap/common/src/bwrap_command.rs Outdated

Copilot AI balanced review requested due to automatic review settings September 30, 2026 21:40

Gudge (MGudgin) force-pushed the user/gudge/move-sdk-policy-types branch from 3ac7782 to e246be7 Compare September 30, 2026 21:40

Copilot started reviewing on behalf of Gudge (MGudgin) September 30, 2026 21:41 View session

Copilot AI reviewed Sep 30, 2026

View reviewed changes

Comment thread docs/authoring-a-new-feature.md Outdated

Comment thread src/core/mxc-sdk/src/lib.rs

Base automatically changed from user/gudge/remove-binding-json-ffi to main October 2, 2026 23:51

Copilot AI balanced review requested due to automatic review settings October 3, 2026 00:04

Gudge (MGudgin) force-pushed the user/gudge/move-sdk-policy-types branch from e246be7 to 4e9465c Compare October 3, 2026 00:04

Copilot started reviewing on behalf of Gudge (MGudgin) October 3, 2026 00:05 View session

Branden Bonaby (bbonaby) approved these changes Oct 3, 2026

View reviewed changes

Copilot AI reviewed Oct 3, 2026

View reviewed changes

Comment thread src/core/mxc-sdk/src/lib.rs

Comment on lines +147 to +149

//! host probing, and execution live in the internal `mxc_engine` crate;

//! `mxc-sdk` owns the public policy/config authoring layer and wraps the

//! engine's streaming handle in [`Sandbox`].

Gudge (MGudgin) merged commit 00a591a into main Oct 3, 2026
24 of 26 checks passed

Gudge (MGudgin) deleted the user/gudge/move-sdk-policy-types branch October 3, 2026 00:09

This was referenced Oct 3, 2026

Restore Rust SDK lifecycle mapper parity tests #1379

Merged

Fix the Linux CI FFI routing test selector #1380

Merged

Navigation Menu

Move the SDK authoring types into mxc-sdk - #1353

Move the SDK authoring types into mxc-sdk#1353
Gudge (MGudgin) merged 1 commit into
mainfrom
user/gudge/move-sdk-policy-types

Gudge (MGudgin) commented Sep 30, 2026 •

edited

Loading

Uh oh!

azure-pipelines Bot commented Sep 30, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Gudge (MGudgin) commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Microsoft Reviewers: Open in CodeFlow

Uh oh!

azure-pipelines Bot commented Sep 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Gudge (MGudgin) commented Sep 30, 2026 •

edited

Loading