Skip to content

Fix clang-format violations in exporter UI changes#976

Closed
Copilot wants to merge 4 commits into
mainfrom
copilot/fix-formatting-check-job
Closed

Fix clang-format violations in exporter UI changes#976
Copilot wants to merge 4 commits into
mainfrom
copilot/fix-formatting-check-job

Conversation

Copilot AI commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

The Formatting Check GitHub Actions job was failing on UI/file/exporter.cpp after the recent exporter cleanup changes. The failure was caused by line wrapping that did not match the repository's clang-format rules.

  • Formatting-only correction

    • Reflowed the newly added DropDownPane::Create(...) call to match the repository's expected wrapping.
    • Reflowed the GetConversionToEMLOptions(...) and ExportIMessageToEML(...) calls in the EML export path to the same style.
  • Scope

    • No functional changes.
    • Keeps the exporter cleanup intact while making the file pass the existing formatting gate.
MyData.AddPane(viewpane::DropDownPane::Create(
	0, IDS_FORMATTOSAVEMESSAGE, static_cast<ULONG>(uidDropDown.size()), uidDropDown.data(), true));

hRes = EC_H(ui::mapiui::GetConversionToEMLOptions(
	pParentWnd, &ulConvertFlags, &et, &mst, &ulWrapLines, &bDoAdrBook));

bwittgen and others added 2 commits June 12, 2026 16:17
* Save Message To File: rename "Text file" dropdown label to
  "XML file (saves all properties of message to an XML file)" so
  the option matches the format it actually produces.

* Fix invalid XML output from every XML exporter (property pane,
  dumpStore, profile, contents-table dump, MrMAPI). The files are
  written as UTF-16 LE (MyOpenFile uses "w, ccs=UNICODE", which
  emits a UTF-16 LE BOM), but g_szXMLHeader declared
  encoding="iso-8859-1", causing every conformant XML parser to
  reject the file. Updated the shared header constant to declare
  encoding="UTF-16".

* Remove the dead "EML file (using PR_INTERNET_CONTENT)" export
  option and its SaveToEML implementation. The PR_INTERNET_CONTENT
  path has not produced usable EML on any modern store for years.

* Add an "Enable legacy features" registry/Options toggle (default
  off). When off, the remaining IConverterSession-based EML export
  option is hidden from the Save Message To File dropdown. The
  export code path is preserved so administrators can re-enable it
  without a rebuild.

* Refactor the exporter dropdown -> exportType mapping from a
  positional static_cast to a switch on GetDropDownValue so the
  enum no longer has to track dropdown ordering. This is what
  makes the gated-row behavior above safe.
Copilot AI changed the title [WIP] Fix failing GitHub Actions job Formatting Check Fix clang-format violations in exporter UI changes Jun 12, 2026
Copilot AI requested a review from bwittgen June 12, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants