Fix CVE for glob 10.4.5 with adjustments to VS Code integration testing#3095
Open
vukelich wants to merge 2 commits into
Open
Fix CVE for glob 10.4.5 with adjustments to VS Code integration testing#3095vukelich wants to merge 2 commits into
vukelich wants to merge 2 commits into
Conversation
…ackage.json to fix glob CVEs about 10.4.5.
…ter doesn't use the results of the former.
vukelich
requested review from
KarishmaGhiya,
alzimmermsft,
g2vinay,
jairmyree,
jongio,
joshfree and
tmeschter
July 17, 2026 22:16
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Component Governance findings around CVE-2026-6734 by making the VS Code integration test’s Playwright dependency deterministic (moving it into package.json / package-lock.json instead of installing it ad-hoc at runtime). It also decouples the VS Code integration stage from the Build stage so the integration stage can run independently (e.g., via stage selection) without requiring Build to execute first.
Changes:
- Move
@playwright/testfrom script-time installation to a pinneddevDependency(and remove the install script wrapper). - Update
package-lock.jsonto reflect the deterministic Playwright dependency tree. - Remove the
Buildstage dependency from theVSCodeIntegrationstage in the pipeline template.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| servers/Azure.Mcp.Server/vscode/package.json | Removes script-based Playwright install and adds @playwright/test as a devDependency for deterministic installs. |
| servers/Azure.Mcp.Server/vscode/package-lock.json | Locks Playwright (and related) packages into the dependency graph to avoid non-deterministic resolution. |
| eng/pipelines/templates/common.yml | Drops the Build stage dependency for VSCodeIntegration, enabling it to run without waiting on Build. |
Files not reviewed (1)
- servers/Azure.Mcp.Server/vscode/package-lock.json: Generated file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Component Governance detection of CVE-2026-6734. Moves the download of the
@playwright/testNPM package intopackage.jsonandpackage-lock.jsonas a realdevDependency. Script-based installation of this package caused non-deterministic package resolution which often caused Azure DevOps build machines to swap the safeglob@10.5.0withglob@10.4.5.I also noticed the VS Code Integration job doesn't use any of the Build job artifacts. I removed that dependency in the build pipeline so that this job can be run quickly and without running the Build or Live Tests jobs. I created #3093 to track a longer-term change to how this job is run or what bits it tests.
GitHub issue number?
Component Governance detection of CVE-2026-6734.
Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline