Migrate Confidential Ledger tools to new tool design#3092
Open
alzimmermsft wants to merge 2 commits into
Open
Conversation
alzimmermsft
requested review from
a team,
ivarprudnikov and
taicchoumsft
as code owners
July 17, 2026 22:05
alzimmermsft
requested review from
JasonYeMSFT,
RickWinter,
anannya03,
hallipr,
sandeep-sen,
vukelich and
xirzec
July 17, 2026 22:05
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Azure Confidential Ledger toolset from the legacy RegisterOptions/BindOptions + System.CommandLine option-definition approach to the newer design where CLI/options binding is driven by [Option] attributes on options POCOs.
Changes:
- Refactors
append/getledger entry commands toAuthenticatedCommand<TOptions, TResult>with attribute-driven options. - Replaces legacy option-definition classes with
[Option]attributes and updates result models torecordtypes. - Removes the
System.CommandLinepackage reference from the Confidential Ledger toolset and updates unit tests accordingly.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.ConfidentialLedger/tests/Azure.Mcp.Tools.ConfidentialLedger.Tests/LedgerEntryGetCommandTests.cs | Updates tests to construct new record-based result types. |
| tools/Azure.Mcp.Tools.ConfidentialLedger/tests/Azure.Mcp.Tools.ConfidentialLedger.Tests/LedgerEntryAppendCommandTests.cs | Updates tests to construct new record-based result types. |
| tools/Azure.Mcp.Tools.ConfidentialLedger/src/Services/ConfidentialLedgerService.cs | Adjusts returned result construction to record constructors and minor refactor. |
| tools/Azure.Mcp.Tools.ConfidentialLedger/src/Options/GetEntryOptions.cs | Migrates to [Option] attribute-based binding and required property semantics. |
| tools/Azure.Mcp.Tools.ConfidentialLedger/src/Options/ConfidentialLedgerOptionDescriptions.cs | Introduces shared option description constants for [Option(Description=...)]. |
| tools/Azure.Mcp.Tools.ConfidentialLedger/src/Options/ConfidentialLedgerOptionDefinitions.cs | Removes legacy System.CommandLine option definitions. |
| tools/Azure.Mcp.Tools.ConfidentialLedger/src/Options/BaseConfidentialLedgerOptions.cs | Replaces legacy JSON-name option mapping with [Option] attributes. |
| tools/Azure.Mcp.Tools.ConfidentialLedger/src/Options/AppendEntryOptions.cs | Migrates to [Option] attribute-based binding and required property semantics. |
| tools/Azure.Mcp.Tools.ConfidentialLedger/src/Models/LedgerEntryGetResult.cs | Converts model to a record with JsonPropertyName on positional properties. |
| tools/Azure.Mcp.Tools.ConfidentialLedger/src/Models/AppendEntryResult.cs | Converts model to a record and removes now-unused request model. |
| tools/Azure.Mcp.Tools.ConfidentialLedger/src/Commands/Entries/LedgerEntryGetCommand.cs | Refactors command execution to the new command base + bound options approach. |
| tools/Azure.Mcp.Tools.ConfidentialLedger/src/Commands/Entries/LedgerEntryAppendCommand.cs | Refactors command execution to the new command base + bound options approach. |
| tools/Azure.Mcp.Tools.ConfidentialLedger/src/Commands/ConfidentialLedgerJsonContext.cs | Removes serialization registration for deleted request type; simplifies context declaration. |
| tools/Azure.Mcp.Tools.ConfidentialLedger/src/Commands/BaseConfidentialLedgerCommand.cs | Deletes legacy base command that depended on System.CommandLine option definitions. |
| tools/Azure.Mcp.Tools.ConfidentialLedger/src/Azure.Mcp.Tools.ConfidentialLedger.csproj | Removes System.CommandLine package reference; updates Core project reference path. |
| servers/Azure.Mcp.Server/changelog-entries/1784325899838.yaml | Adds a changelog entry marking the breaking change for the toolset. |
Comment on lines
4
to
8
| using System.CommandLine; | ||
| using Azure.Mcp.Tools.ConfidentialLedger.Models; | ||
| using Azure.Mcp.Tools.ConfidentialLedger.Options; | ||
| using Azure.Mcp.Tools.ConfidentialLedger.Services; | ||
| using Microsoft.Extensions.Logging; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates Confidential Ledger tools to new design where Register and Bind options are based on
Optionattributes.GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline