Migrate Managed Lustre tools to new tool design#3078
Open
alzimmermsft wants to merge 1 commit into
Open
Conversation
alzimmermsft
requested review from
a team,
rebecca-makar and
wolfgang-desalvador
as code owners
July 17, 2026 12:54
alzimmermsft
requested review from
KarishmaGhiya,
g2vinay,
hallipr,
jairmyree,
tmeschter,
vukelich and
xirzec
July 17, 2026 12:54
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Azure Managed Lustre toolset to the attribute-based options design (where option registration/binding is derived from [Option] / [OptionContainer]), removing the legacy RegisterOptions/BindOptions + System.CommandLine option-definition pattern and updating tests accordingly.
Changes:
- Converted Managed Lustre commands to the newer
SubscriptionCommand<TOptions, TResult>execution model with attribute-based option POCOs. - Removed legacy option-definition and base-command infrastructure (
ManagedLustreOptionDefinitions,BaseManagedLustreCommand,System.CommandLinedependency). - Updated Managed Lustre unit tests to use the newer command test base classes and explicit
Xunitusings.
Reviewed changes
Copilot reviewed 72 out of 72 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/Usings.cs | Removes global Xunit using; shifts tests to explicit using Xunit;. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/ManagedLustreHsmJobsCollection.cs | Adds explicit Xunit using after global using removal. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/ManagedLustreCommandTests.cs | Adds explicit Xunit using after global using removal. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/SubnetSize/SubnetSizeValidateCommandTests.cs | Updates tests to new command testing base and updated namespaces. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/SubnetSize/SubnetSizeAskCommandTests.cs | Updates tests to new command testing base and updated namespaces. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/Sku/SkuGetCommandTests.cs | Updates tests to new command testing base and updated namespaces. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/ImportJob/ImportJobGetCommandTests.cs | Updates tests for new result shape and new testing base. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/ImportJob/ImportJobDeleteCommandTests.cs | Updates tests to new command testing base and updated namespaces. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/ImportJob/ImportJobCreateCommandTests.cs | Updates tests to new command testing base and updated namespaces. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/ImportJob/ImportJobCancelCommandTests.cs | Updates tests to new command testing base and updated namespaces. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/FileSystemUpdateCommandTests.cs | Updates tests to new command testing base and updated namespaces. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/FileSystemListCommandTests.cs | Updates tests to new command testing base and updated namespaces. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/FileSystemCreateCommandTests.cs | Updates tests to new command testing base and updated namespaces. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/AutoimportJob/AutoimportJobGetCommandTests.cs | Updates tests to new command testing base and updated namespaces. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/AutoimportJob/AutoimportJobDeleteCommandTests.cs | Updates tests to new command testing base and updated namespaces. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/AutoimportJob/AutoimportJobCreateCommandTests.cs | Updates tests to new command testing base and updated namespaces. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/AutoimportJob/AutoimportJobCancelCommandTests.cs | Updates tests to new command testing base and updated namespaces. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/AutoexportJob/AutoexportJobGetCommandTests | Updates tests to new command testing base and updated namespaces. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/AutoexportJob/AutoexportJobDeleteCommandTests.cs | Updates tests to new command testing base and updated namespaces. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/AutoexportJob/AutoexportJobCreateCommandTests.cs | Updates tests to new command testing base and updated namespaces. |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.Tests/FileSystem/AutoexportJob/AutoexportJobCancelCommandTests.cs | Updates tests to new command testing base and updated namespaces. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Services/ManagedLustreService.cs | Minor formatting update to service method signature for readability. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Services/IManagedLustreService.cs | Normalizes some service return types and signatures during migration. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/ManagedLustreOptionDescriptions.cs | Introduces centralized option description strings for [Option] attributes. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/ManagedLustreOptionDefinitions.cs | Removes legacy System.CommandLine-based option definitions. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/SubnetSize/SubnetSizeValidateOptions.cs | Converts options to attribute-based POCO implementing ISubscriptionOption. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/SubnetSize/SubnetSizeAskOptions.cs | Converts options to attribute-based POCO implementing ISubscriptionOption. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/Sku/SkuGetOptions.cs | Converts options to attribute-based POCO implementing ISubscriptionOption. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/ImportJob/ImportJobGetOptions.cs | Converts options to attribute-based POCO and adds required RG/filesystem fields. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/ImportJob/ImportJobDeleteOptions.cs | Converts options to attribute-based POCO and adds required RG/filesystem fields. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/ImportJob/ImportJobCreateOptions.cs | Converts options to attribute-based POCO and adds required RG/filesystem fields. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/ImportJob/ImportJobCancelOptions.cs | Converts options to attribute-based POCO and adds required RG/filesystem fields. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/FileSystemUpdateOptions.cs | Converts options to attribute-based POCO and updates option property naming. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/FileSystemListOptions.cs | Converts options to attribute-based POCO (subscription + optional RG). |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/FileSystemCreateOptions.cs | Converts options to attribute-based POCO and inlines some option descriptions. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoimportJob/AutoimportJobListOptions.cs | Removes legacy list options type (handled by updated get/list behavior). |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoimportJob/AutoimportJobGetOptions.cs | Converts options to attribute-based POCO and adds required RG/filesystem fields. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoimportJob/AutoimportJobDeleteOptions.cs | Converts options to attribute-based POCO and adds required RG/filesystem fields. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoimportJob/AutoimportJobCreateOptions.cs | Converts options to attribute-based POCO and adds required RG/filesystem fields. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoimportJob/AutoimportJobCancelOptions.cs | Converts options to attribute-based POCO and adds required RG/filesystem fields. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoexportJob/AutoexportJobListOptions.cs | Removes legacy list options type (handled by updated get/list behavior). |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoexportJob/AutoexportJobGetOptions.cs | Converts options to attribute-based POCO and adds required RG/filesystem fields. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoexportJob/AutoexportJobDeleteOptions.cs | Converts options to attribute-based POCO and adds required RG/filesystem fields. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoexportJob/AutoexportJobCreateOptions.cs | Converts options to attribute-based POCO and adds required RG/filesystem fields. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/FileSystem/AutoexportJob/AutoexportJobCancelOptions.cs | Converts options to attribute-based POCO and adds required RG/filesystem fields. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Options/BaseManagedLustreOptions.cs | Removes legacy base options type derived from SubscriptionOptions. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Models/ManagedLustreSkuInfo.cs | Updates models to use C# primary constructors. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/ManagedLustreSetup.cs | Updates imports for moved command namespaces (Sku/SubnetSize). |
| tools/Azure.Mcp.Tools.ManagedLustre/src/GlobalUsings.cs | Removes legacy global using for System.CommandLine. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/ManagedLustreJsonContext.cs | Updates JSON source-gen registrations to match new result types and formatting options. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/ManagedLustreCommonValidators.cs | Introduces shared validation helpers for option validation in new command design. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/SubnetSize/SubnetSizeValidateCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/SubnetSize/SubnetSizeAskCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/Sku/SkuGetCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/ImportJob/ImportJobGetCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> and unifies get/list response shape. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/ImportJob/ImportJobDeleteCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/ImportJob/ImportJobCreateCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/ImportJob/ImportJobCancelCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/FileSystemUpdateCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> with updated validation flow. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/FileSystemListCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/FileSystemCreateCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> with new validation flow. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/AutoimportJob/AutoimportJobGetCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> and unifies get/list response shape. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/AutoimportJob/AutoimportJobDeleteCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/AutoimportJob/AutoimportJobCreateCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/AutoimportJob/AutoimportJobCancelCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/AutoexportJob/AutoexportJobGetCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> and unifies get/list response shape. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/AutoexportJob/AutoexportJobDeleteCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/AutoexportJob/AutoexportJobCreateCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/AutoexportJob/AutoexportJobCancelCommand.cs | Migrates command to SubscriptionCommand<TOptions, TResult> and attribute-bound options. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/BaseManagedLustreCommand.cs | Removes legacy base command implementation that depended on manual binding. |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Azure.Mcp.Tools.ManagedLustre.csproj | Removes System.CommandLine dependency and updates core project reference path. |
| servers/Azure.Mcp.Server/changelog-entries/1784292789378.yaml | Adds changelog entry for Managed Lustre tool changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates Managed Lustre tools to new design where Register and Bind options are based on
Optionattributes.GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline