[EngSys] Lint workflows with actionlint#3076
Open
mikeharder wants to merge 2 commits into
Open
Conversation
mikeharder
commented
Jul 16, 2026
mikeharder
commented
Contributor
- Same config as our other repos
- Same config as our other repos
mikeharder
requested review from
chidozieononiwu,
conniey,
hallipr,
msalaman,
saikoumudi,
vukelich and
xirzec
July 16, 2026 23:48
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an actionlint GitHub Actions workflow (plus matcher/config) to lint this repo’s workflows, and makes small tweaks to an existing workflow likely to satisfy actionlint/shellcheck.
Changes:
- Add a new
.github/workflows/actionlint.ymlworkflow to run actionlint on.github/**changes. - Add an Actionlint problem matcher (
.github/matchers/actionlint.json) and actionlint config (.github/actionlint.yaml) to ignore*.lock.ymlworkflows. - Update the existing event processor workflow to quote
$GITHUB_ENVredirections and change the Azure loginclient-id.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/event-processor.yml | Quotes $GITHUB_ENV writes and changes Azure OIDC client-id used by azure/login. |
| .github/workflows/actionlint.yml | New workflow that runs actionlint (container) and registers a problem matcher. |
| .github/matchers/actionlint.json | Adds a problem matcher to surface actionlint findings as GitHub annotations. |
| .github/actionlint.yaml | Configures actionlint to ignore .github/workflows/*.lock.yml files. |
mikeharder
commented
Jul 17, 2026
| if: ${{ github.event_name == 'issues' && github.event.action == 'opened' }} | ||
| with: | ||
| client-id: a6dd2dfe-7352-41a7-9020-05301c3bca1a | ||
| client-id: e4cb9fd5-0875-4ca1-bc43-56196f5dfb8f |
Contributor
Author
There was a problem hiding this comment.
change caused by updating file from it's source in the azure-sdk-tools repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.