Migrate Marketplace tools to new tool design#3070
Open
alzimmermsft wants to merge 1 commit into
Open
Conversation
alzimmermsft
requested review from
chidozieononiwu,
conniey,
hallipr,
msalaman,
saikoumudi,
vukelich and
xirzec
July 16, 2026 18:02
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the Azure Marketplace toolset commands to the newer “options POCO + [Option] attributes” design, removing the legacy RegisterOptions/BindOptions(ParseResult) plumbing and updating unit tests accordingly.
Changes:
- Converted
ProductGet/ProductListcommands toSubscriptionCommand<TOptions, TResult>with attribute-bound options. - Replaced the old
MarketplaceOptionDefinitionsoption-registration pattern with[Option]/[OptionContainer]onProductGetOptionsandProductListOptions. - Updated Marketplace unit tests to use
SubscriptionCommandUnitTestsBaseand the new binding flow.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Marketplace/tests/Azure.Mcp.Tools.Marketplace.Tests/Product/ProductListCommandTests.cs | Updates test base to subscription-aware unit test base. |
| tools/Azure.Mcp.Tools.Marketplace/tests/Azure.Mcp.Tools.Marketplace.Tests/Product/ProductGetCommandTests.cs | Updates test base to subscription-aware unit test base. |
| tools/Azure.Mcp.Tools.Marketplace/src/Services/MarketplaceService.cs | Adds explicit System.Text.Json import after removing toolset global usings. |
| tools/Azure.Mcp.Tools.Marketplace/src/Options/Product/ProductListOptions.cs | Replaces SubscriptionOptions inheritance with [Option]-attributed POCO implementing ISubscriptionOption. |
| tools/Azure.Mcp.Tools.Marketplace/src/Options/Product/ProductGetOptions.cs | Replaces SubscriptionOptions inheritance with [Option]-attributed POCO implementing ISubscriptionOption. |
| tools/Azure.Mcp.Tools.Marketplace/src/Options/MarketplaceOptionDescriptions.cs | Centralizes shared option description strings (e.g., language). |
| tools/Azure.Mcp.Tools.Marketplace/src/Options/MarketplaceOptionDefinitions.cs | Removes legacy System.CommandLine option-definition constants and Option<T> instances. |
| tools/Azure.Mcp.Tools.Marketplace/src/GlobalUsings.cs | Removes toolset-level global usings for System.CommandLine and System.Text.Json. |
| tools/Azure.Mcp.Tools.Marketplace/src/Commands/Product/ProductListCommand.cs | Migrates command execution to the new options-binding and result-typing model. |
| tools/Azure.Mcp.Tools.Marketplace/src/Commands/Product/ProductGetCommand.cs | Migrates command execution to the new options-binding and result-typing model. |
| tools/Azure.Mcp.Tools.Marketplace/src/Commands/MarketplaceJsonContext.cs | Formatting-only tweak to source-gen options attribute layout. |
| tools/Azure.Mcp.Tools.Marketplace/src/Azure.Mcp.Tools.Marketplace.csproj | Removes direct System.CommandLine dependency and updates core project reference path. |
| servers/Azure.Mcp.Server/changelog-entries/1784224695208.yaml | Adds a changelog entry for the Marketplace tool changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates Marketplace tools to new design where Register and Bind options are based on
Optionattributes.GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline