Skip to content

Migrate Marketplace tools to new tool design#3070

Open
alzimmermsft wants to merge 1 commit into
microsoft:mainfrom
alzimmermsft:MigrateMarketplaceToolsToNewDesign
Open

Migrate Marketplace tools to new tool design#3070
alzimmermsft wants to merge 1 commit into
microsoft:mainfrom
alzimmermsft:MigrateMarketplaceToolsToNewDesign

Conversation

@alzimmermsft

Copy link
Copy Markdown
Contributor

What does this PR do?

Migrates Marketplace tools to new design where Register and Bind options are based on Option attributes.

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@alzimmermsft alzimmermsft self-assigned this Jul 16, 2026
Copilot AI review requested due to automatic review settings July 16, 2026 18:02
@alzimmermsft
alzimmermsft requested review from a team and meirloichter as code owners July 16, 2026 18:02
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates the Azure Marketplace toolset commands to the newer “options POCO + [Option] attributes” design, removing the legacy RegisterOptions/BindOptions(ParseResult) plumbing and updating unit tests accordingly.

Changes:

  • Converted ProductGet / ProductList commands to SubscriptionCommand<TOptions, TResult> with attribute-bound options.
  • Replaced the old MarketplaceOptionDefinitions option-registration pattern with [Option]/[OptionContainer] on ProductGetOptions and ProductListOptions.
  • Updated Marketplace unit tests to use SubscriptionCommandUnitTestsBase and the new binding flow.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/Azure.Mcp.Tools.Marketplace/tests/Azure.Mcp.Tools.Marketplace.Tests/Product/ProductListCommandTests.cs Updates test base to subscription-aware unit test base.
tools/Azure.Mcp.Tools.Marketplace/tests/Azure.Mcp.Tools.Marketplace.Tests/Product/ProductGetCommandTests.cs Updates test base to subscription-aware unit test base.
tools/Azure.Mcp.Tools.Marketplace/src/Services/MarketplaceService.cs Adds explicit System.Text.Json import after removing toolset global usings.
tools/Azure.Mcp.Tools.Marketplace/src/Options/Product/ProductListOptions.cs Replaces SubscriptionOptions inheritance with [Option]-attributed POCO implementing ISubscriptionOption.
tools/Azure.Mcp.Tools.Marketplace/src/Options/Product/ProductGetOptions.cs Replaces SubscriptionOptions inheritance with [Option]-attributed POCO implementing ISubscriptionOption.
tools/Azure.Mcp.Tools.Marketplace/src/Options/MarketplaceOptionDescriptions.cs Centralizes shared option description strings (e.g., language).
tools/Azure.Mcp.Tools.Marketplace/src/Options/MarketplaceOptionDefinitions.cs Removes legacy System.CommandLine option-definition constants and Option<T> instances.
tools/Azure.Mcp.Tools.Marketplace/src/GlobalUsings.cs Removes toolset-level global usings for System.CommandLine and System.Text.Json.
tools/Azure.Mcp.Tools.Marketplace/src/Commands/Product/ProductListCommand.cs Migrates command execution to the new options-binding and result-typing model.
tools/Azure.Mcp.Tools.Marketplace/src/Commands/Product/ProductGetCommand.cs Migrates command execution to the new options-binding and result-typing model.
tools/Azure.Mcp.Tools.Marketplace/src/Commands/MarketplaceJsonContext.cs Formatting-only tweak to source-gen options attribute layout.
tools/Azure.Mcp.Tools.Marketplace/src/Azure.Mcp.Tools.Marketplace.csproj Removes direct System.CommandLine dependency and updates core project reference path.
servers/Azure.Mcp.Server/changelog-entries/1784224695208.yaml Adds a changelog entry for the Marketplace tool changes.

Comment thread servers/Azure.Mcp.Server/changelog-entries/1784224695208.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants