Migrate MySql tools to new tool design#3069
Open
alzimmermsft wants to merge 1 commit into
Open
Conversation
alzimmermsft
requested review from
KarishmaGhiya,
RickWinter,
g2vinay,
jairmyree,
jongio,
joshfree and
tmeschter
July 16, 2026 17:26
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Azure MySql toolset from the legacy “RegisterOptions/BindOptions + System.CommandLine OptionDefinitions” pattern to the newer [Option]-attribute-based option binding used across the repo.
Changes:
- Refactors MySql commands to use
SubscriptionCommand<TOptions, TResult>with POCO options attributed via[Option]. - Removes legacy MySql option/command base classes and
System.CommandLine-specific option definition types from the toolset. - Updates unit tests and project references/dependencies to align with the new command + options shape.
Reviewed changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.Tests/Table/TableSchemaGetCommandTests.cs | Updates command test base to the subscription-command test harness. |
| tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.Tests/Services/MySqlServiceTests.cs | Updates service construction after logger removal. |
| tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.Tests/Services/MySqlServiceServerNameValidationTests.cs | Updates service construction after logger removal. |
| tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.Tests/Server/ServerParamSetCommandTests.cs | Updates command test base to the subscription-command test harness. |
| tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.Tests/Server/ServerParamGetCommandTests.cs | Updates command test base to the subscription-command test harness. |
| tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.Tests/Server/ServerConfigGetCommandTests.cs | Updates command test base to the subscription-command test harness. |
| tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.Tests/MySqlListCommandTests.cs | Updates list command tests for new binding/test harness. |
| tools/Azure.Mcp.Tools.MySql/tests/Azure.Mcp.Tools.MySql.Tests/Database/DatabaseQueryCommandTests.cs | Updates command test base to the subscription-command test harness. |
| tools/Azure.Mcp.Tools.MySql/src/Services/MySqlService.cs | Removes logger dependency; keeps existing service behavior. |
| tools/Azure.Mcp.Tools.MySql/src/Options/BaseMySqlOptions.cs | Replaces legacy JSON-property options with [Option]-attributed POCO options. |
| tools/Azure.Mcp.Tools.MySql/src/Options/MySqlListOptions.cs | Adds new options type for list routing scenarios. |
| tools/Azure.Mcp.Tools.MySql/src/Options/MySqlOptionDescriptions.cs | Introduces shared option description constants for reuse. |
| tools/Azure.Mcp.Tools.MySql/src/Options/MySqlOptionDefinitions.cs | Removes legacy System.CommandLine Option<> definitions. |
| tools/Azure.Mcp.Tools.MySql/src/Options/Database/DatabaseQueryOptions.cs | Migrates query option to [Option]-based binding. |
| tools/Azure.Mcp.Tools.MySql/src/Options/Database/DatabaseListOptions.cs | Removes legacy options type. |
| tools/Azure.Mcp.Tools.MySql/src/Options/Server/ServerParamGetOptions.cs | Migrates param-get options to [Option]-based binding. |
| tools/Azure.Mcp.Tools.MySql/src/Options/Server/ServerParamSetOptions.cs | Migrates param-set options to [Option]-based binding. |
| tools/Azure.Mcp.Tools.MySql/src/Options/Server/ServerConfigGetOptions.cs | Removes legacy options type. |
| tools/Azure.Mcp.Tools.MySql/src/Options/Server/ServerListOptions.cs | Removes legacy options type. |
| tools/Azure.Mcp.Tools.MySql/src/Options/Table/TableSchemaGetOptions.cs | Migrates table schema options to [Option]-based binding. |
| tools/Azure.Mcp.Tools.MySql/src/Options/Table/TableListOptions.cs | Removes legacy options type. |
| tools/Azure.Mcp.Tools.MySql/src/Commands/MySqlListCommand.cs | Refactors to new subscription command design + POCO validation. |
| tools/Azure.Mcp.Tools.MySql/src/Commands/MySqlJsonContext.cs | Simplifies source-gen context definition syntax. |
| tools/Azure.Mcp.Tools.MySql/src/Commands/Database/DatabaseQueryCommand.cs | Refactors to new subscription command design + POCO binding. |
| tools/Azure.Mcp.Tools.MySql/src/Commands/Database/BaseDatabaseCommand.cs | Removes legacy command base class. |
| tools/Azure.Mcp.Tools.MySql/src/Commands/Server/ServerConfigGetCommand.cs | Refactors to new subscription command design + POCO binding. |
| tools/Azure.Mcp.Tools.MySql/src/Commands/Server/ServerParamGetCommand.cs | Refactors to new subscription command design + POCO binding. |
| tools/Azure.Mcp.Tools.MySql/src/Commands/Server/ServerParamSetCommand.cs | Refactors to new subscription command design + POCO binding. |
| tools/Azure.Mcp.Tools.MySql/src/Commands/Server/BaseServerCommand.cs | Removes legacy command base class. |
| tools/Azure.Mcp.Tools.MySql/src/Commands/Table/TableSchemaGetCommand.cs | Refactors to new subscription command design + POCO binding. |
| tools/Azure.Mcp.Tools.MySql/src/GlobalUsings.cs | Removes legacy global using for System.CommandLine. |
| tools/Azure.Mcp.Tools.MySql/src/Azure.Mcp.Tools.MySql.csproj | Updates core project reference style; drops direct System.CommandLine dependency. |
| servers/Azure.Mcp.Server/changelog-entries/1784222764751.yaml | Adds breaking-change entry for MySql tool option surface changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates MySql tools to new design where Register and Bind options are based on
Optionattributes.GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline