Repository navigation
fix(ocr): preserve native PDF conversion without an OCR client - #2627
Open
LeonSGP (LeonSGP43) wants to merge 1 commit into
Open
LeonSGP (LeonSGP43) wants to merge 1 commit into
LeonSGP (LeonSGP43) wants to merge 1 commit into
Conversation
|
LeonSGP (@LeonSGP43) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the OCR plugin is registered without an OCR client, it currently replaces native PDF conversion with its own
page.extract_text()pipeline. This contradicts the documented built-in fallback and loses table column positions and word spacing in machine-readable PDFs. For example, the existing sparse inventory fixture loses all 22 Markdown table lines, including the positions of blank cells.Delegate to the existing
PdfConverterwhen no OCR service is configured. Preserve the converter's stream rewind and forward conversion arguments. Configured OCR continues through its existing implementation. Regression tests exercise public plugin registration and conversion, plus direct conversion with an advanced stream cursor, using three existing real PDF fixtures.Validation on macOS with Python 3.12.8 and sibling checkout imports:
python -m pytestin the already provisioned official Hatch test environment withGITHUB_ACTIONS=1; no new environment or dependency installation. The skips are the suite's conditional cases, not newly excluded tests.pre-commit run --all-files: Black passed.compileall, source import/runtime checks, andgit diff --checkpassed.Other Python/OS CI matrix legs and remote OCR services were not exercised locally. No model or external OCR call was required. This change restores the documented no-client fallback; it does not address configured-OCR scanning or layout issues in #2343 or #2566.
AI-assisted by gpt-6.1-sol; implementation and verification evidence were reviewed locally.