Skip to content

fix(json): remove redundant guard in get_child_node #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baywet merged 2 commits into from
May 28, 2026
Merged

fix(json): remove redundant guard in get_child_node #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1230131
fix(json): remove redundant guard in get_child_node
gntikos May 28, 2026
8e9f778
test(json): Use fictional names in test values
gntikos May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/serialization/json/kiota_serialization_json/json_parse_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@ def get_child_node(self, identifier: str) -> Optional[ParseNode]:
Returns:
Optional[ParseNode]: A new parse node for the given identifier
"""
if not identifier:
raise ValueError("identifier cannot be None or empty.")

if isinstance(node := self._json_node, dict) and identifier in node:
return self._create_new_node(node[identifier])
return None
Expand Down
13 changes: 13 additions & 0 deletions packages/serialization/json/tests/unit/test_json_parse_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,19 @@ def test_get_float_value_from_float():
assert result == 44.6


def test_get_child_node_not_found():
parse_node = JsonParseNode({"name": "Jane Smith"})
result = parse_node.get_child_node("age")
assert result is None


def test_get_child_node_empty_name():
parse_node = JsonParseNode({"": "John Smith"})
result = parse_node.get_child_node("")
assert result is not None
assert result.get_str_value() == "John Smith"


@pytest.mark.parametrize("value", [0, 10, 100])
def test_get_float_value(value: int):
"""
Expand Down
Loading