Repository navigation
fix: line endings and other build script issues (#828) - #830
Open
Matteo Scaramuccia (scara) wants to merge 4 commits into
Open
Matteo Scaramuccia (scara) wants to merge 4 commits into
Matteo Scaramuccia (scara) wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The build script excludes required third-party license attributions from NOTICE.md and leaves absolute path expansions unquoted, breaking builds when the checkout path contains spaces.
2 open issues
What changed in this PR
This PR addresses the cross-platform development issues reported in #828, focusing on line endings, DevContainer tool discovery, and build-script paths.
Changes:
- Set explicit line endings for shell scripts, Windows scripts, and output fixtures.
- Add Go-installed tools to the DevContainer’s
PATH. - Resolve build-script paths absolutely and adjust license-report filtering.
| File | Description |
|---|---|
build/build.sh |
Updates path resolution, template lookup, and license-report exclusions. |
.gitattributes |
Enforces platform-specific line endings for scripts and fixtures. |
.devcontainer/Dockerfile |
Adds ${GOPATH}/bin to PATH for Go-installed tools. |
Review effort: Balanced
Comment on lines
+8
to
+10
| --ignore github.com/microsoft \ | ||
| --ignore golang.org/x/sys \ | ||
| --ignore github.com/cespare/xxhash \ |
Fixed the following issue when calling the build script using `build/build.sh` instead of `./build/build.sh`: ``` package cmd/modern is not in std (/usr/local/go/src/cmd/modern) ``` Besides, quote every subsequent expansion of `scriptdir`, even though the standard checkout path does not contain spaces.
Matteo Scaramuccia (scara)
force-pushed
the
fix/828-dev-cointainer-lf-path-build-issues
branch
from
November 15, 2026 16:25
024c128 to
6055fde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR addresses those items listed in #828, though not strictly required since the project is successfully releasing Linux binaries too.
@microsoft-github-policy-service agree
HTH,
Matteo