Skip to content

fix: line endings and other build script issues (#828) - #830

Open
Matteo Scaramuccia (scara) wants to merge 4 commits into
microsoft:mainfrom
scara:fix/828-dev-cointainer-lf-path-build-issues
Open

Matteo Scaramuccia (scara) wants to merge 4 commits into
microsoft:mainfrom
scara:fix/828-dev-cointainer-lf-path-build-issues

Conversation

@scara

Copy link
Copy Markdown

This PR addresses those items listed in #828, though not strictly required since the project is successfully releasing Linux binaries too.

@microsoft-github-policy-service agree

HTH,
Matteo

Copilot AI balanced review requested due to automatic review settings November 15, 2026 15:59
@scara Matteo Scaramuccia (scara) changed the title Fix LF and other build script issues (#828) Fix: CRLF vs LF and other build script issues (#828) Nov 15, 2026
@scara Matteo Scaramuccia (scara) changed the title Fix: CRLF vs LF and other build script issues (#828) fix: CRLF vs LF and other build script issues (#828) Nov 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The build script excludes required third-party license attributions from NOTICE.md and leaves absolute path expansions unquoted, breaking builds when the checkout path contains spaces.

2 open issues
What changed in this PR

This PR addresses the cross-platform development issues reported in #828, focusing on line endings, DevContainer tool discovery, and build-script paths.

Changes:

  • Set explicit line endings for shell scripts, Windows scripts, and output fixtures.
  • Add Go-installed tools to the DevContainer’s PATH.
  • Resolve build-script paths absolutely and adjust license-report filtering.
File Description
build/​build.sh Updates path resolution, template lookup, and license-report exclusions.
.gitattributes Enforces platform-specific line endings for scripts and fixtures.
.devcontainer/​Dockerfile Adds ${GOPATH}/bin to PATH for Go-installed tools.

Review effort: Balanced

Comment thread build/build.sh Outdated
Comment on lines +8 to +10
--ignore github.com/microsoft \
--ignore golang.org/x/sys \
--ignore github.com/cespare/xxhash \
Comment thread build/build.sh Resolved
@scara Matteo Scaramuccia (scara) changed the title fix: CRLF vs LF and other build script issues (#828) fix: line endings and other build script issues (#828) Nov 15, 2026
Fixed the following issue when calling the build script using
`build/build.sh` instead of `./build/build.sh`:
```
package cmd/modern is not in std (/usr/local/go/src/cmd/modern)
```
Besides, quote every subsequent expansion of `scriptdir`, even though
the standard checkout path does not contain spaces.
@scara
Matteo Scaramuccia (scara) force-pushed the fix/828-dev-cointainer-lf-path-build-issues branch from 024c128 to 6055fde Compare November 15, 2026 16:25
Copilot AI balanced review requested due to automatic review settings November 15, 2026 16:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the cross-platform development changes.

1 open issue
1 resolved since last review

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants