Repository navigation
fix: avoid panic on empty arguments (#826) - #829
Open
Matteo Scaramuccia (scara) wants to merge 1 commit into
Open
Matteo Scaramuccia (scara) wants to merge 1 commit into
Matteo Scaramuccia (scara) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change addressing empty-argument panics in sqlcmd.
No open issues 🎉
What changed in this PR
This PR prevents panics when sqlcmd processes empty command-line arguments, with a minimal change to argument normalization and regression tests.
Changes:
- Guard flag detection against empty strings and reuse it when checking optional flag defaults.
- Add tests for empty argument values and existing optional-default behavior.
| File | Description |
|---|---|
cmd/sqlcmd/sqlcmd.go |
Safely handles empty strings during flag detection and optional-value checks. |
cmd/sqlcmd/sqlcmd_test.go |
Adds regression coverage for empty connection, list, optional, and standalone arguments. |
Review effort: Balanced
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal fix proposal, including a regression test addressing #826.