Skip to content

Fix Helm chart version synchronization - #2088

Open
Emre Şafak (esafak) wants to merge 3 commits into
microsoft:mainfrom
esafak:fix/helm-chart-version-sync
Open

Fix Helm chart version synchronization#2088
Emre Şafak (esafak) wants to merge 3 commits into
microsoft:mainfrom
esafak:fix/helm-chart-version-sync

Conversation

@esafak

@esafak Emre Şafak (esafak) commented Aug 26, 2026

Copy link
Copy Markdown

Why?

The OCI workflow could publish a chart whose metadata diverged from the repository. It also missed normal chart changes because it only watched Chart.yaml; the latest helm chart is over a year old.

This PR will...

  • Trigger OCI chart publishing for all changes under charts/** and for Version.props changes.
  • Keep the Git chart version and appVersion aligned with the Garnet release version.
  • Fail before packaging if either chart value differs from Version.props.

Testing

  • git diff --check
  • actionlint .github/workflows/helm-chart.yml (only the pre-existing SC2044 warning for the find-based packaging loop remains)
  • Reviewer verification confirmed the chart metadata is Helm-valid and the version check passes for 2.1.5.

@esafak

Emre Şafak (esafak) commented Aug 26, 2026

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree company="Archipelago AI"

1 similar comment
@esafak

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree company="Archipelago AI"

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Synchronizes Helm chart metadata with Garnet’s canonical release version and broadens OCI publishing triggers.

Changes:

  • Aligns chart version and appVersion with Version.props.
  • Validates version consistency before packaging.
  • Triggers publishing for all chart and version changes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
charts/garnet/Chart.yaml Updates chart metadata to version 2.1.5.
.github/workflows/helm-chart.yml Expands triggers and adds version validation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread charts/garnet/Chart.yaml
Comment on lines +5 to +6
version: 2.1.5
appVersion: 2.1.5

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in commits 5e67d73 and c4cc01a. The checked-in README now shows Version 2.1.5 and AppVersion 2.1.5, and the README template retains chart.badgesSection so future helm-docs regeneration uses the chart metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants