Restrict WinML discovery to trusted execution providers - #940
Open
baijumeswani wants to merge 1 commit into
Open
Restrict WinML discovery to trusted execution providers#940baijumeswani wants to merge 1 commit into
baijumeswani wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a case-insensitive allowlist limiting WinML catalog discovery to approved execution providers.
Changes:
- Filters unapproved WinML providers during enumeration.
- Adds unit coverage for accepted and rejected provider names.
- Registers the new tests in the C++ test target.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
sdk_v2/cpp/src/ep_detection/winml_provider_allowlist.h |
Defines the provider allowlist. |
sdk_v2/cpp/src/ep_detection/winml_ep_bootstrapper.cc |
Applies filtering during discovery. |
sdk_v2/cpp/test/internal_api/winml_provider_allowlist_test.cc |
Tests allowlist behavior. |
sdk_v2/cpp/test/CMakeLists.txt |
Adds the test source. |
Comment on lines
+291
to
+294
| if (!IsTrustedWinMLProvider(provider_name)) { | ||
| ctx->logger->Log(LogLevel::Information, | ||
| fmt::format("WinML EP ignored because it is not trusted: {}", provider_name)); | ||
| return TRUE; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a case-insensitive allowlist for WinML execution providers. Untrusted providers are ignored during catalog discovery.
WebGPU ep was being discovered from winml ep catalog as well as from FL's ep catalog causing a conflict. This PR filters our webgpu ep from winml ep catalog.