Skip to content

adds win arm64 test/build stages to v2 pipeline - #917

Open
prathikr wants to merge 7 commits into
mainfrom
prathikrao/win-arm64-pipeline-support-2
Open

adds win arm64 test/build stages to v2 pipeline#917
prathikr wants to merge 7 commits into
mainfrom
prathikrao/win-arm64-pipeline-support-2

Conversation

@prathikr

@prathikr prathikr commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Gives us complete testing coverage across all our targeted platforms

Copilot AI review requested due to automatic review settings July 27, 2026 15:57
@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
foundry-local Ready Ready Preview, Comment Jul 27, 2026 10:14pm

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds native Windows ARM64 build and test coverage across the v2 SDK pipeline.

Changes:

  • Enables Windows ARM64 C++, C#, Python, and JavaScript builds/tests.
  • Bootstraps required Windows tooling, runtimes, Azure CLI, and test data.
  • Adds ARM64 Python loading and more tolerant ASR assertions.

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
sdk_v2/python/src/foundry_local_sdk/_native/lib_loader.py Resolves Windows ARM64 native libraries.
sdk_v2/js/package-lock.json Updates native dependency metadata.
sdk_v2/cs/test/FoundryLocal.Tests/Utils.cs Adds transcript normalization helper.
sdk_v2/cs/test/FoundryLocal.Tests/AudioSessionTests.cs Uses semantic transcript assertions.
sdk_v2/cs/test/FoundryLocal.Tests/AudioClientTests.cs Relaxes ASR output checks.
.pipelines/v2/templates/steps-test-python.yml Supports ARM64 Python testing.
.pipelines/v2/templates/steps-test-js.yml Supports Windows ARM64 JavaScript tests.
.pipelines/v2/templates/steps-test-cs.yml Supports Windows ARM64 C# tests.
.pipelines/v2/templates/steps-prefetch-nuget.yml Makes the PowerShell host configurable.
.pipelines/v2/templates/steps-build-windows.yml Enables native ARM64 C++ builds/tests.
.pipelines/v2/templates/steps-build-python.yml Builds Python wheels natively on ARM64.
.pipelines/v2/templates/steps-build-js.yml Builds Node addons on Windows ARM64.
.pipelines/v2/templates/stages-python.yml Adds native ARM64 Python stages.
.pipelines/v2/templates/stages-js.yml Adds native ARM64 JavaScript stages.
.pipelines/v2/templates/stages-cs.yml Adds the ARM64 C# test stage.
.pipelines/v2/templates/stages-build-native.yml Moves native builds/tests to ARM64 agents.
.pipelines/templates/fetch-test-data-from-blob.yml Bootstraps Azure CLI and AzCopy on ARM64.
Files not reviewed (1)
  • sdk_v2/js/package-lock.json: Generated file

Comment thread sdk_v2/python/src/foundry_local_sdk/_native/lib_loader.py
Comment thread .pipelines/v2/templates/steps-build-js.yml Outdated
Comment thread .pipelines/v2/templates/steps-test-js.yml
Comment thread sdk_v2/cs/test/FoundryLocal.Tests/AudioClientTests.cs Outdated
Comment thread .pipelines/v2/templates/stages-python.yml Outdated
Comment thread sdk_v2/js/package-lock.json
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment thread sdk_v2/js/package-lock.json
Write-Host "Using system Python: $python3Path"

- task: PowerShell@2
displayName: 'Bootstrap VC++ ARM64 runtime'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this bootstrap doing?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it should be fixed in the image rather than doing this in the pipeline.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eserscor is this something you could help us with?

version: '8.0.x'

- task: PowerShell@2
displayName: 'Bootstrap VC++ ARM64 runtime'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems duplicated. Could we factor this out into a template to avoid duplication? Or ask Erik if this can be baked into the image?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants