Harden runtime packaging and native loading - #902
Draft
bmehta001 wants to merge 2 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Package required ORT, GenAI, WinML, and DirectML runtime companions consistently across C++, JS, and Python packaging paths. Avoid logging caller-provided package URLs and make CMake package extraction work with older CMake versions. Files changed: - pipeline packaging/build templates - sdk_v2/cpp/cmake/FindOnnxRuntime*.cmake and FindWinMLEpCatalog.cmake - sdk_v2/cpp/nuget/pack.py - sdk_v2/js/package metadata and prebuild scripts - sdk_v2/python native lib loader Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 297bc539-5f7f-4a70-9411-48e91a5bf532
bmehta001
force-pushed
the
bhamehta/flcore/runtime-packaging-hardening
branch
from
July 24, 2026 22:26
443182c to
01908f1
Compare
The packaging pipeline requires DirectML.dll alongside Microsoft.Windows.AI.MachineLearning.dll, but CMake only copied the WinML library. Copy DirectML from the same architecture-specific runtime directory during post-build staging. Files changed: - sdk_v2/cpp/CMakeLists.txt Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 297bc539-5f7f-4a70-9411-48e91a5bf532
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation