Skip to content

fix(containerd2): temporarily build with Go 1.26 #18713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aadhar-agarwal wants to merge 1 commit into
base: 3.0-dev
Choose a base branch
from
+13 −2
Open

fix(containerd2): temporarily build with Go 1.26 #18713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions SPECS/containerd2/containerd2.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
Summary: Industry-standard container runtime
Name: %{upstream_name}2
Version: 2.2.4
Release: 7%{?dist}
Release: 8%{?dist}
License: ASL 2.0
Group: Tools/Container
URL: https://www.containerd.io
Expand Down Expand Up @@ -36,7 +36,9 @@ Patch16: CVE-2026-56852.patch

%{?systemd_requires}

BuildRequires: golang
# Temporarily stay on Go 1.26 until the Go 1.27 ML-KEM backend is fixed.
BuildRequires: golang >= 1.26.7
BuildRequires: golang < 1.27
Comment on lines +40 to +41

@mfrw Muhammad Falak R Wani (mfrw) Sep 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about: Cosmetic/Non-Blocking

Suggested change
BuildRequires: golang >= 1.26.7
BuildRequires: golang < 1.27
BuildRequires: (golang >= 1.26.7 with golang < 1.27)

BuildRequires: go-md2man
BuildRequires: make
BuildRequires: systemd-rpm-macros
Expand Down Expand Up @@ -70,10 +72,13 @@ used directly by developers or end-users.

%build
export BUILDTAGS="-mod=vendor"
# Go 1.26 requires this experiment for cgo-less OpenSSL systemcrypto.
export GOEXPERIMENT=ms_nocgo_opensslcrypto
make VERSION="%{version}" REVISION="%{commit_hash}" binaries man

%check
export BUILDTAGS="-mod=vendor"
export GOEXPERIMENT=ms_nocgo_opensslcrypto
make VERSION="%{version}" REVISION="%{commit_hash}" test

%install
Expand Down Expand Up @@ -109,6 +114,12 @@ fi
%dir /opt/containerd/lib

%changelog
* Thu Sep 03 2026 Aadhar Agarwal <aadagarwal@microsoft.com> - 2.2.4-8
- Temporarily build with Microsoft Go 1.26 to avoid the Go 1.27 systemcrypto
ML-KEM panic on OpenSSL 3.3.
- Restore GOEXPERIMENT=ms_nocgo_opensslcrypto for the Go 1.26 cgo-less OpenSSL
backend.

* Wed Sep 02 2026 Muhammad Falak R Wani <mwani@microsoft.com> - 2.2.4-7
- Drop 'GOEXPERIMENT=ms_nocgo_opensslcrypto', removed in Go 1.27. Systemcrypto is
now selected automatically and supports CGO_ENABLED=0 on Linux.
Expand Down
Loading