Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python: Add function_loop_max_iterations to create_harness_agent #7346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Python: Add function_loop_max_iterations to create_harness_agent #7346
Changes from all commits
af05201File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assertion locks in mutating the caller-owned client as the contract, but
create_harness_agentpasses that sameclientobject straight intoAgent(...)andAgentstores it by reference. That meanscreate_harness_agent(shared_client, function_loop_max_iterations=7)followed bycreate_harness_agent(shared_client, function_loop_max_iterations=3)will silently change the first agent's cap to 3 as well. The .NET harness avoids this by configuring function invocation on a harness-owned wrapper instead of mutating the caller's client. Consider not cementing the shared-mutation behavior in tests; add coverage for reusing one client across two agents and keep the cap agent-local.Uh oh!
There was an error while loading. Please reload this page.