Python: isolate dependency-bound validation - #7342
Open
eavanvalkenburg wants to merge 3 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e446e833-ea7c-44e8-8b73-e730e30160af
eavanvalkenburg
temporarily deployed
to
github-app-auth
July 27, 2026 09:38 — with
GitHub Actions
Inactive
eavanvalkenburg
temporarily deployed
to
github-app-auth
July 27, 2026 09:38 — with
GitHub Actions
Inactive
eavanvalkenburg
temporarily deployed
to
github-app-auth
July 27, 2026 09:38 — with
GitHub Actions
Inactive
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes false dependency-bound validation conflicts in the Python workspace by ensuring package probes only follow the selected dependency groups/extras for internal editable dependencies, preventing aggregate surfaces (e.g., core[all]) from leaking into unrelated validations. It also updates agent-framework-ag-ui to validate FastAPI through the 0.139.x line and adds regression coverage for the new editable-resolution behavior.
Changes:
- Introduce shared workspace package metadata loading + a selected-surface internal-editables resolver, and use it across upper-bound, lower-bound, and test-mode validation flows.
- Add unit tests to prevent regressions in internal editable closure behavior (selected surface only; propagate explicitly requested transitive extras).
- Update AG-UI’s FastAPI upper bound to
<0.140.0and add atestdependency group requiringagent-framework-orchestrations(with corresponding lock updates).
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| python/uv.lock | Updates AG-UI metadata (FastAPI bound + test group editable dependency) in the lockfile. |
| python/scripts/dependencies/validate_dependency_bounds.py | Switches test-mode planning to shared workspace config + selected-surface internal editables resolution. |
| python/scripts/dependencies/tests/test_dependency_bounds_runtime.py | Adds regression tests covering internal editable closure semantics. |
| python/scripts/dependencies/README.md | Documents the refined internal editable resolution behavior (selected groups/extras only). |
| python/scripts/dependencies/_dependency_bounds_upper_impl.py | Uses shared workspace config + selected-surface editable resolution in upper-bound validation. |
| python/scripts/dependencies/_dependency_bounds_runtime.py | Adds WorkspacePackageConfig, workspace config loader, and resolve_internal_editables. |
| python/scripts/dependencies/_dependency_bounds_lower_impl.py | Uses shared workspace config + selected-surface editable resolution in lower-bound validation. |
| python/packages/ag-ui/pyproject.toml | Expands FastAPI supported range and adds test dependency group for orchestrations. |
eavanvalkenburg
marked this pull request as ready for review
July 27, 2026 09:43
eavanvalkenburg
temporarily deployed
to
github-app-auth
July 27, 2026 09:43 — with
GitHub Actions
Inactive
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e446e833-ea7c-44e8-8b73-e730e30160af
eavanvalkenburg
temporarily deployed
to
github-app-auth
July 27, 2026 09:45 — with
GitHub Actions
Inactive
giles17
approved these changes
Jul 27, 2026
eavanvalkenburg
enabled auto-merge
July 28, 2026 05:29
moonbox3
reviewed
Jul 28, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e446e833-ea7c-44e8-8b73-e730e30160af
eavanvalkenburg
temporarily deployed
to
github-app-auth
July 28, 2026 12:49 — with
GitHub Actions
Inactive
eavanvalkenburg
temporarily deployed
to
github-app-auth
July 28, 2026 12:49 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
The dependency maintenance workflow reported newer FastAPI candidates for
agent-framework-ag-uias incompatiblebefore package checks could run. Package-scoped probes were following every optional extra and dependency group on
transitive workspace packages, so AG-UI's dependency on core pulled in the unrelated
core[all]surface and DevUI'sFastAPI constraint.
This prevented valid dependency-bound updates and could produce similar false conflicts in upper-bound, lower-bound,
and test-mode validation.
Description & Review Guide
consistently across upper-bound, lower-bound, and test-mode validation. Allow packages to define an implementation-
focused
dependency-pyrighttask, guard core tests that require optional integrations, add regression coverage,declare AG-UI's orchestration test dependency, and expand its validated FastAPI range through 0.139.x.
unrelated aggregate extras from transitive packages. Core remains valid in an isolated install without connector
packages, while normal repository checks still cover its lazy namespace stubs. AG-UI now supports
fastapi>=0.121.0,<0.140.0.of explicitly requested extras while excluding unselected aggregate surfaces such as
core[all].Related Issue
Fixes #7339
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.