Skip to content

Size new arena chunks from the previous chunk's capacity #65031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jake Bailey (jakebailey) merged 3 commits into from
Oct 30, 2026
Merged

Size new arena chunks from the previous chunk's capacity #65031

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21e624a
Size new arena chunks from the previous chunk's capacity
jakebailey Oct 29, 2026
20dfbb7
Add regression test for arena growth from a partial chunk
jakebailey Oct 29, 2026
8480a06
Remove arena growth white-box test
jakebailey Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tsc/internal/core/arena.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type Arena[T any] struct {
// capacity and unrelated values retained by a surviving pointer into a chunk.
func (a *Arena[T]) New() *T {
if len(a.data) == cap(a.data) {
nextSize := nextArenaSize[T](len(a.data))
nextSize := nextArenaSize[T](cap(a.data))
// Use the same trick as slices.Concat; Grow rounds up to the next size class.
a.data = slices.Grow[[]T](nil, nextSize)
}
Expand All @@ -33,7 +33,7 @@ func (a *Arena[T]) NewSlice(size int) []T {
return nil
}
if len(a.data)+size > cap(a.data) {
nextSize := nextArenaSize[T](len(a.data))
nextSize := nextArenaSize[T](cap(a.data))
Comment thread
jakebailey marked this conversation as resolved.
Resolved
if size > nextSize {
return make([]T, size)
}
Expand Down
Loading