Skip to content

Split link store lookups into inlineable fast paths #65019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jake Bailey (jakebailey) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Split link store lookups into inlineable fast paths #65019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions tsc/internal/core/linkstore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,17 @@ type LinkStore[K comparable, V any] struct {
}

func (s *LinkStore[K, V]) Get(key K) *V {
value := s.entries[key]
if value != nil {
if value := s.entries[key]; value != nil {
return value
}
return s.getSlow(key)
}

func (s *LinkStore[K, V]) getSlow(key K) *V {
if s.entries == nil {
s.entries = make(map[K]*V)
}
value = s.arena.New()
value := s.arena.New()
s.entries[key] = value
return value
}
Expand Down Expand Up @@ -49,6 +52,13 @@ type PagedLinkStore[V any] struct {
}

func (s *PagedLinkStore[V]) Get(key uint64) *V {
if link := s.TryGet(key); link != nil {
return link
}
return s.getSlow(key)
}

func (s *PagedLinkStore[V]) getSlow(key uint64) *V {
pageIndex := key >> LinkPageShift
if int(pageIndex) >= len(s.pages) {
// Grow the length of the list to pageIndex+1
Expand Down
Loading