Bump and clean up deps, raise min local node version - #64054
Open
Jake Bailey (jakebailey) wants to merge 14 commits into
Open
Bump and clean up deps, raise min local node version#64054Jake Bailey (jakebailey) wants to merge 14 commits into
Jake Bailey (jakebailey) wants to merge 14 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Modernizes local tooling dependencies and raises the development Node.js minimum.
Changes:
- Replaces several dependencies with Node.js APIs or lightweight helpers.
- Migrates process execution from
execatotinyexec. - Aligns Node.js typings and updates package dependencies.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
Herebyfile.mjs |
Reworks task execution and dependency-backed utilities. |
.github/workflows/ci.yml |
Adds Herebyfile type-checking. |
package.json |
Raises Node minimum and prunes dependencies. |
package-lock.json |
Updates resolved dependencies. |
packages/typescript/package.json |
Updates scripts and Node typings. |
packages/vscode-typescript/package.json |
Updates TAS client. |
packages/typescript/scripts/generateSync.ts |
Migrates formatter execution. |
tools/scripts/tsc/generate-ts-ast.ts |
Migrates formatter execution. |
tools/scripts/tsc/generate-go-ast.ts |
Migrates formatter execution. |
tools/scripts/tsc/generate-encoder.ts |
Migrates formatter execution. |
tsc/internal/lsp/lsproto/_generate/generate.mts |
Updates Node invocation and execution helper. |
tsc/internal/lsp/lsproto/_generate/fetchModel.mts |
Updates Node invocation. |
tsc/internal/stringutil/generate.go |
Removes the type-stripping flag. |
tsc/internal/stringutil/_scripts/generate-unicode-data.mts |
Simplifies the shebang. |
packages/typescript/src/api/node/wtf8.ts |
Adapts decoder types to Node 22 typings. |
packages/typescript/src/api/node/node.infrastructure.ts |
Narrows the internal decoder contract. |
packages/typescript/src/api/node/encoder.ts |
Imports Node’s TextEncoder. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to update and prune our deps; this PR:
adm-zip, no more audit errortmpin favor of node's builtin tmpdir func--experimental-type-strippingeverywhereglobwith node's globbingpicocolorswith node'sstyleTextp-limitwith a small local helperexecawithtinyexecwhich@types/node@22consistently