Skip to content

Bump and clean up deps, raise min local node version - #64054

Open
Jake Bailey (jakebailey) wants to merge 14 commits into
microsoft:mainfrom
jakebailey:new-node-deps
Open

Bump and clean up deps, raise min local node version#64054
Jake Bailey (jakebailey) wants to merge 14 commits into
microsoft:mainfrom
jakebailey:new-node-deps

Conversation

@jakebailey

Copy link
Copy Markdown
Member

I'm trying to update and prune our deps; this PR:

  • Bumps adm-zip, no more audit error
  • Removes tmp in favor of node's builtin tmpdir func
  • Raises the min node for local dev to 22.18, removing --experimental-type-stripping everywhere
  • Replaces glob with node's globbing
  • Replaces picocolors with node's styleText
  • Replaces p-limit with a small local helper
  • Replaces execa with tinyexec
  • Remove which
  • Use @types/node@22 consistently

Copilot AI balanced review requested due to automatic review settings August 27, 2026 17:35
@github-project-automation github-project-automation Bot moved this to Not started in PR Backlog Aug 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Modernizes local tooling dependencies and raises the development Node.js minimum.

Changes:

  • Replaces several dependencies with Node.js APIs or lightweight helpers.
  • Migrates process execution from execa to tinyexec.
  • Aligns Node.js typings and updates package dependencies.

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Herebyfile.mjs Reworks task execution and dependency-backed utilities.
.github/workflows/ci.yml Adds Herebyfile type-checking.
package.json Raises Node minimum and prunes dependencies.
package-lock.json Updates resolved dependencies.
packages/typescript/package.json Updates scripts and Node typings.
packages/vscode-typescript/package.json Updates TAS client.
packages/typescript/scripts/generateSync.ts Migrates formatter execution.
tools/scripts/tsc/generate-ts-ast.ts Migrates formatter execution.
tools/scripts/tsc/generate-go-ast.ts Migrates formatter execution.
tools/scripts/tsc/generate-encoder.ts Migrates formatter execution.
tsc/internal/lsp/lsproto/_generate/generate.mts Updates Node invocation and execution helper.
tsc/internal/lsp/lsproto/_generate/fetchModel.mts Updates Node invocation.
tsc/internal/stringutil/generate.go Removes the type-stripping flag.
tsc/internal/stringutil/_scripts/generate-unicode-data.mts Simplifies the shebang.
packages/typescript/src/api/node/wtf8.ts Adapts decoder types to Node 22 typings.
packages/typescript/src/api/node/node.infrastructure.ts Narrows the internal decoder contract.
packages/typescript/src/api/node/encoder.ts Imports Node’s TextEncoder.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/ci.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Not started

Development

Successfully merging this pull request may close these issues.

2 participants