Clear stale incremental diagnostics after JSON module changes - #64026
Open
Jake Bailey (jakebailey) with Copilot wants to merge 3 commits into
Open
Clear stale incremental diagnostics after JSON module changes#64026Jake Bailey (jakebailey) with Copilot wants to merge 3 commits into
Jake Bailey (jakebailey) with Copilot wants to merge 3 commits into
Conversation
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incremental diagnostics not clearing after JSON file fix
Clear stale incremental diagnostics after JSON module changes
Aug 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates incremental compilation so JSON content changes invalidate dependent diagnostics.
Changes:
- Uses JSON file versions as shape signatures.
- Adds a regression test covering property removal and restoration.
- Adds the expected incremental-build baseline.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tsc/internal/execute/incremental/affectedfileshandler.go |
Handles JSON shape signatures correctly. |
tsc/internal/execute/tsctests/tsc_test.go |
Adds the regression scenario. |
tsc/testdata/baselines/reference/tsc/incremental/json-module-diagnostics-are-cleared-after-fixing-the-json-file.js |
Records expected diagnostics and invalidation behavior. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Jake Bailey (jakebailey)
marked this pull request as ready for review
August 26, 2026 16:19
Jake Bailey (jakebailey)
approved these changes
Aug 26, 2026
Jake Bailey (jakebailey)
requested review from
Andrew Branch (andrewbranch) and
Gabriela Araujo Britto (gabritto)
August 26, 2026 22:48
Gabriela Araujo Britto (gabritto)
approved these changes
Aug 26, 2026
Jake Bailey (jakebailey)
requested review from
Gabriela Araujo Britto (gabritto) and
Wesley Wigham (weswigham)
August 26, 2026 23:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incremental builds retained diagnostics from an earlier JSON module shape after the JSON file was fixed.
--incremental: diagnostics caused by a JSON module are never cleared after the JSON file is fixed (7.0.2) #64025