[api] Add .isReadonlySymbol() method - #63943
Merged
Andrew Branch (andrewbranch) merged 10 commits intoAug 27, 2026
Merged
Conversation
Signed-off-by: mrazauskas <tom@mrazauskas.de>
typescript-automation
Bot
added
For Uncommitted Bug
|
The TypeScript team hasn't accepted the linked issue #63828. If you can get it accepted, this PR will have a better chance of being reviewed. |
Copilot started reviewing on behalf of
Tom Mrazauskas (mrazauskas)
August 21, 2026 06:07
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Checker.isReadonlySymbol() to expose compiler readonly-symbol detection through the TypeScript API.
Changes:
- Adds the checker and protocol endpoint.
- Implements synchronous and asynchronous client methods.
- Adds API tests for
constandletsymbols.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tsc/internal/checker/exports.go |
Exposes readonly-symbol detection. |
tsc/internal/api/session.go |
Handles the new API request. |
tsc/internal/api/proto.go |
Registers the protocol method. |
packages/typescript/src/api/proto.generated.ts |
Adds protocol typing. |
packages/typescript/src/api/sync/api.ts |
Adds the synchronous API. |
packages/typescript/src/api/async/api.ts |
Adds the asynchronous API. |
packages/typescript/test/sync/api.test.ts |
Tests the synchronous API. |
packages/typescript/test/async/api.test.ts |
Tests the asynchronous API. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: mrazauskas <tom@mrazauskas.de>
Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>
Andrew Branch (andrewbranch)
approved these changes
Aug 26, 2026
Andrew Branch (andrewbranch)
enabled auto-merge
August 26, 2026 15:12
Signed-off-by: mrazauskas <tom@mrazauskas.de>
auto-merge was automatically disabled
August 27, 2026 04:05
Head branch was pushed to by a user without write access
Tom Mrazauskas (mrazauskas)
requested a review
from Andrew Branch (andrewbranch)
August 27, 2026 06:26
Andrew Branch (andrewbranch)
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
.isReadonlySymbol()method to the checker instance.Fixes #63828
Fixes #31296