Reduce live test flakiness update actions with v5#2699
Open
robgruen wants to merge 34 commits into
Open
Conversation
…peAgent into dev/robgruen/flakey
# Conflicts: # ts/packages/dispatcher/dispatcher/README.AUTOGEN.md
…actions
The playerSchema.agr renamed two actions in a prior commit but the variant
fixture grammars and benchmark JSONL were left with the old names:
- `resume` → `resumePlayback`
- `playTrack` (flat params) → `playMusic` (target: { kind, ... } params)
This caused `generateAllDeltas()` to produce 466 spurious deltas (vs the 25
committed rows) because every resume and play-by-artist corpus entry created
a delta between HEAD and each variant.
Changes:
- v1-v9 variant .agr files: Resume rules updated to `resumePlayback`;
PlaySpecificTrack rules updated to `playMusic` with target-nested params
- player.regression-benchmark.jsonl: 3 v1-lost-transport rows updated
(actionA.actionName `resume` → `resumePlayback`)
- player.utterances.jsonl: corpus expectedAction fields updated to new names
(resume → resumePlayback, playTrack → playMusic with new parameter structure)
…peAgent into dev/robgruen/flakey
…tructionCacheResolver test
…peAgent into dev/robgruen/flakey
- Revert test back to \"play despacito\" (no artist required) - Add \"isOptional\": true to the artist sub-phrase in basic.json - Add \"optional\": true to M:artist name_7 in constructions.json so track-only utterances (no artist) match the play construction
…peAgent into dev/robgruen/flakey
robgruen
marked this pull request as ready for review
July 18, 2026 04:59
robgruen
enabled auto-merge
July 18, 2026 04:59
GeorgeNgMsft
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the GitHub Actions workflows and related test code to use the latest versions of key actions and improves test reliability. The main changes include upgrading all
actions/checkout,actions/setup-node,actions/upload-artifact, andactions/download-artifactsteps to their latest major versions, updating documentation and comments for clarity, and improving the reliability of test assertions intranslateTestCommon.ts.CI Workflow Upgrades
actions/checkoutfromv4tov5across workflow files for improved performance and new features. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]actions/setup-nodefromv4tov5for Node.js setup steps. [1] [2] [3] [4] [5] [6] [7] [8]actions/upload-artifactandactions/download-artifactfromv4tov5for artifact handling. [1] [2] [3] [4]CodeQL and Workflow Documentation Updates
Test Reliability Improvement
checkPossibleMatchtest helper intranslateTestCommon.tsto ignore non-deterministicentitiesfields unless explicitly specified in the expected result, reducing spurious test failures.