Streamline electron package#2688
Merged
hillary-mutisya merged 13 commits intoJul 18, 2026
Merged
Conversation
- Switch default behavior for shell launch to connect to a running agent-server instance. If none is running, the shell will launch one, matching the behavior of CLI. - Add `--standalone` flag which alllows launching shell with in-proc hosted agent-server, for dev environments that want previous behavior. - Update electron packaging to only include platform-specific packages e.g. only x64 copilot sdk packages when building x64. - Mark the onnxruntime components used for local embedding as optional. Remove them from shell package since emebeddings would run in agent-server. - Together, the last 2 changes cut 40% of the shell installer size.
robgruen
approved these changes
Jul 17, 2026
hillary-mutisya
enabled auto-merge
July 17, 2026 16:56
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
Move `initRuntimeConfigFromProcessEnv` and `warmupCopilotFromConfig` out of `populateKeys`/`tryLoadYamlConfig` into a new `warmupRuntimeConfig` export that is called only when running in standalone mode (in-process agent-server). The connect-only shell never imports aiclient, keeping it out of the dependency closure. Also guard continuous-speech processing behind `isLocalSpeechProcessingSupported()`, which skips local classification when the configured provider is Copilot (unavailable in the pruned connect-only shell). Update `prune-shell-deploy.mjs` to drop ALL platform-native packages for `@github/copilot` and `@anthropic-ai/claude-agent-sdk` (not just the non-host arch), while preserving the small JS wrapper packages.
hillary-mutisya
disabled auto-merge
July 17, 2026 22:26
Member
|
@hillary-mutisya Does the |
Collaborator
Author
|
@curtisman , good call. I'm tracking the agent registration as a separate change (#2697). I'll make sure that PR goes in before this one. |
Move browser and markdown view-service startup off the agent enable path by forking in the background, preventing startup delays from view-service timeouts. Preserve and update crash cleanup/port registration logic once the child process is ready, and rewire markdown UI context after late process creation. Also lazy-load `urlResolver` in browser URL resolution to avoid eager module loading during startup.
hillary-mutisya
enabled auto-merge
July 18, 2026 08:55
|
I do work in agent mode. Reluctantly |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--standaloneflag which alllows launching shell with in-proc hosted agent-server, for dev environments that want previous behavior.