Repository navigation
loopguard: ignore structured file-diff dicts in response_text (#151) - #152
Open
Tejas Lamba (TejasLamba2006) wants to merge 1 commit into
Open
Tejas Lamba (TejasLamba2006) wants to merge 1 commit into
Tejas Lamba (TejasLamba2006) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151.
While checking #151 against recorded Claude Code transcripts on my machine, I noticed two places where
response_textfeeds edited file contents intoERR_RE:Editreturns{filePath, oldString, newString, originalFile, structuredPatch, ...}with none of_RESPONSE_KEYS, soresponse_textfell back tojson.dumps(resp).Writereturns{type, filePath, content, originalFile, structuredPatch, ...}, wherecontentis the written file body.Replaying
response_textacross 964 local Claude Code session logs (37,797 structuredtoolUseResultdicts), 12,279 successfulEdit/Writecalls matchedERR_REbefore this change and 0 after. Real edit failures still arrive throughPostToolUseFailure(_failure_response), which carrieserrorwithoutstructuredPatch.