Add AGENTS.md and per-TFM MSBuild loader skills - #381
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Test class is QueryInstancesTests (plural); the singular form did not substring-match in dotnet test --filter. - Unregister() is a documented no-op kept only for back-compat; calling the section 'register/unregister' suggested behavior that does not exist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The AssemblyLoadContext-vs-AppDomain handler split, the ResolveDotnetPathCandidates probe order, the hostfxr API names, the VS Setup COM details, and the net46-vs-netcore gating for VisualStudioLocationHelper are already covered in the two loader skill files. Keeping them in AGENTS.md as well burns the always-loaded context budget for work that only touches one TFM. Replace the per-TFM lines with pointers to the relevant skill while keeping the multi-targeting heads-up (TFM list + conditional compilation constants) so agents still know to check both forks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Jan Provazník (JanProvaznik)
approved these changes
Jun 4, 2026
Veronika Ovsyannikova (OvesN)
approved these changes
Jun 18, 2026
Clarified platform-specific code requirements for .NET SDK discovery.
Split the props/targets guidance into the core no-copy rule and keeping the target's package list in sync. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2b3282da-484d-4b88-8a92-e2db9c2dac8e
…uildLocator into agent-instructions Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2b3282da-484d-4b88-8a92-e2db9c2dac8e
Copilot started reviewing on behalf of
Rainer Sigwald (rainersigwald)
August 27, 2026 22:01
View session
There was a problem hiding this comment.
Pull request overview
Adds repository-wide Copilot guidance and targeted documentation for each MSBuild loader implementation.
Changes:
- Documents repository architecture, workflows, and conventions.
- Adds .NET SDK loader guidance.
- Adds .NET Framework and Visual Studio loader guidance.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
AGENTS.md |
Adds shared repository instructions. |
.agents/skills/msbuild-loader-netcore/SKILL.md |
Documents net8.0 SDK discovery and loading. |
.agents/skills/msbuild-loader-netframework/SKILL.md |
Documents net46 Visual Studio discovery and loading. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2b3282da-484d-4b88-8a92-e2db9c2dac8e
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2b3282da-484d-4b88-8a92-e2db9c2dac8e
…uildLocator into agent-instructions
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2b3282da-484d-4b88-8a92-e2db9c2dac8e
Veronika Ovsyannikova (OvesN)
approved these changes
Aug 28, 2026
Veronika Ovsyannikova (OvesN)
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MSBuildLocator's implementation forks heavily between
net46(Visual Studio) andnet8.0(.NET SDK). This PR adds Copilot agent instructions and splits the documentation into an always-loaded base file and two on-demand skills to prevent context bloat and confusion between the frameworks.What's added
AGENTS.md: Core repository context, build/test commands, conventions, and the cross-TFM register-before-load contract.msbuild-loader-netcoreskill:net8.0/NETCOREAPPspecifics (AssemblyLoadContext, hostfxr SDK discovery, probe order, SDK environment variables).msbuild-loader-netframeworkskill:net46specifics (AppDomain.AssemblyResolve, Developer Console / VS Setup COM discovery).Notes
AGENTS.mdpretty manually but the skills are generated.