fix(test): allow all-nodes log generator on Windows 2025 - #1791
Open
zanejohnson-azure wants to merge 2 commits into
Open
zanejohnson-azure wants to merge 2 commits into
zanejohnson-azure wants to merge 2 commits into
Conversation
Remove the Windows2022-only node selector so the Windows log generator also schedules on Windows Server 2025 nodes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
suyadav1
approved these changes
Sep 24, 2026
zanejohnson-azure
enabled auto-merge (squash)
September 24, 2026 22:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove only
kubernetes.azure.com/os-sku: Windows2022fromtest/scenario/log-gen-all-nodes-daemonset.yaml.The remaining
kubernetes.io/os: windowsselector allows the DaemonSet to schedule on both Windows Server 2022 and Windows Server 2025 nodes. The existingservercore:ltsc2022image is supported on Windows Server 2025 with process isolation (compatibility matrix).Coverage
The existing Testkube
containerstatus-windowsworkflow is not restricted to a Windows Server version. Forci-logs-dev-aks-all-nodes, the pipeline also enablesPerNodeLogCoverage=true, which expects container log ingestion from every cluster node, including a Windows Server 2025 node once added. The tests do not require a Win25 node to exist.Deployment
After adding the Windows Server 2025 node, reapply this DaemonSet manifest to the cluster. The current build pipeline deploys ama-logs but does not apply this log-generator manifest.
No pipeline, agent image, test implementation, or cluster configuration changes are included.