Skip to content

Prevent shell injection in ConfigMap-derived environment settings - #1790

Open
suyadav1 wants to merge 3 commits into
ci_prodfrom
suyadav/fix-configmap-shell-quoting
Open

suyadav1 wants to merge 3 commits into
ci_prodfrom
suyadav/fix-configmap-shell-quoting

Conversation

@suyadav1

Copy link
Copy Markdown
Contributor

Summary

  • Validate container-log schema/route versions and shell-quote all generated Linux environment values.
  • Preserve escaping when appending settings to .bashrc; add injection and compatibility regressions.

Validation

  • 69 Ruby tests, 5,046 assertions passed (--disable-error_highlight required for a pre-existing baseline test issue).
  • 28 Linux/Windows configuration comparisons matched ci_prod; the original injection paths fail the new regressions.
  • Live-agent and native Windows execution remain untested.

@suyadav1
suyadav1 requested a review from a team as a code owner September 23, 2026 17:51
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

suyadav1 and others added 2 commits September 24, 2026 21:46
Remove the outdated Windows Telegraf update comment.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Telegraf 1.40.1 bump and Windows note removal belong to PR #1764, not this ConfigMap shell-quoting PR. Reverts commit 44237c6.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant