Remove diskann-providers benchmarks and its criterion/iai-callgrind dev-deps

[harsha-simhadri]

Summary

Removes the entire diskann-providers/benches/ directory and drops the criterion and iai-callgrind dev-dependencies from the diskann-providers crate.

Changes

• Deleted diskann-providers/benches/ (both harnesses):
  • criterion harness: bench_main.rs + benches/benchmarks/ (compute_pq, diskann, neighbor)
  • iai-callgrind harness: bench_main_iai.rs + benches/benchmarks_iai/
• Removed the criterion and iai-callgrind dev-dependencies and the two [[bench]] sections from diskann-providers/Cargo.toml.
• Regenerated Cargo.lock (drops these two from diskann-providers's dependency list only).

Notes

• criterion and iai-callgrind remain workspace dependencies; diskann-disk, diskann-vector, and diskann-label-filter still use them.
• The virtual_storage feature is retained (used by CI, diskann-disk, diskann-tools, and src/storage).
• No CI workflow ran these micro-benchmarks.

Validation

• cargo build -p diskann-providers --features virtual_storage — success.
• cargo clippy --workspace --all-targets -- -D warnings — clean across all crates.

[Copilot]

Pull request overview

This PR cleans up the diskann-providers crate by removing its local micro-benchmark harnesses and dropping the benchmark-only dev-dependencies, while keeping criterion/iai-callgrind available at the workspace level for other crates that still use them.

Changes:

• Removed criterion and iai-callgrind from diskann-providers dev-dependencies and deleted the [[bench]] targets from diskann-providers/Cargo.toml.
• Deleted the entire diskann-providers/benches/ directory (criterion + iai-callgrind harnesses).
• Updated Cargo.lock to reflect the removed crate-level dependency edges.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
diskann-providers/Cargo.toml	Removes benchmark dev-deps and bench target entries from diskann-providers.
diskann-providers/benches/bench_main.rs	Deletes the criterion benchmark harness entrypoint.
diskann-providers/benches/bench_main_iai.rs	Deletes the iai-callgrind benchmark harness entrypoint.
diskann-providers/benches/benchmarks/mod.rs	Deletes the criterion benchmarks module wiring.
diskann-providers/benches/benchmarks/compute_pq_bench.rs	Deletes criterion PQ computation benchmark.
diskann-providers/benches/benchmarks/diskann_bench.rs	Deletes criterion DiskANN async insert benchmark.
diskann-providers/benches/benchmarks/neighbor_bench.rs	Deletes criterion NeighborPriorityQueue benchmarks.
diskann-providers/benches/benchmarks_iai/mod.rs	Deletes the iai-callgrind benchmarks module wiring.
diskann-providers/benches/benchmarks_iai/compute_pq_iai.rs	Deletes iai-callgrind PQ computation benchmark.
diskann-providers/benches/benchmarks_iai/diskann_iai.rs	Deletes iai-callgrind DiskANN async insert benchmark.
diskann-providers/benches/benchmarks_iai/neighbor_bench_iai.rs	Deletes iai-callgrind NeighborPriorityQueue benchmarks.
Cargo.lock	Removes criterion / iai-callgrind from diskann-providers’ locked dependency list.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.64%. Comparing base (be48520) to head (cda6c7b).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1220   +/-   ##
=======================================
  Coverage   89.64%   89.64%           
=======================================
  Files         503      503           
  Lines       95695    95695           
=======================================
  Hits        85787    85787           
  Misses       9908     9908           

Flag	Coverage Δ
miri	89.64% <ø> (ø)
unittests	89.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.