Skip to content

Add BC block copy support to CopyRectangle #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nv3ifu (nv3ifu) wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add BC block copy support to CopyRectangle #752

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27f3c09
Add BC block copy support to CopyRectangle
nv3ifu Oct 9, 2026
a898119
Apply clang-format to CopyRectangle BC copy code
nv3ifu Oct 10, 2026
9a63b88
Restructure CopyRectangle format handling
nv3ifu Oct 16, 2026
747156e
Merge remote-tracking branch 'origin/main' into copyrectangle-bc-blocks
nv3ifu Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
190 changes: 124 additions & 66 deletions DirectXTex/DirectXTexMisc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,100 +260,158 @@ _Use_decl_annotations_ HRESULT DirectX::CopyRectangle(const Image& srcImage,
if (!srcImage.pixels || !dstImage.pixels)
return E_POINTER;

if (IsCompressed(srcImage.format) || IsCompressed(dstImage.format) || IsPlanar(srcImage.format) || IsPlanar(dstImage.format)
|| IsPalettized(srcImage.format) || IsPalettized(dstImage.format))
if (IsPlanar(srcImage.format) || IsPlanar(dstImage.format) || IsPalettized(srcImage.format) || IsPalettized(dstImage.format))
return HRESULT_E_NOT_SUPPORTED;

// Validate rectangle/offset
if (!srcRect.w || !srcRect.h || ((srcRect.x + srcRect.w) > srcImage.width) || ((srcRect.y + srcRect.h) > srcImage.height))
if (IsCompressed(srcImage.format) || IsCompressed(dstImage.format))
{
return E_INVALIDARG;
}
if (srcImage.format != dstImage.format)
return HRESULT_E_NOT_SUPPORTED;

if (((xOffset + srcRect.w) > dstImage.width) || ((yOffset + srcRect.h) > dstImage.height))
{
return E_INVALIDARG;
}
const size_t bytesPerBlock = BytesPerBlock(srcImage.format);
if (!bytesPerBlock)
return HRESULT_E_NOT_SUPPORTED;

// Compute source bytes-per-pixel
size_t sbpp = BitsPerPixel(srcImage.format);
if (!sbpp)
return E_INVALIDARG;
if (!srcRect.w || !srcRect.h || srcRect.x >= srcImage.width || srcRect.y >= srcImage.height
|| srcRect.w > srcImage.width - srcRect.x || srcRect.h > srcImage.height - srcRect.y || xOffset >= dstImage.width
|| yOffset >= dstImage.height || srcRect.w > dstImage.width - xOffset || srcRect.h > dstImage.height - yOffset)
return E_INVALIDARG;

if (sbpp < 8)
{
// We don't support monochrome (DXGI_FORMAT_R1_UNORM)
return HRESULT_E_NOT_SUPPORTED;
}
// Copy whole 4x4 blocks covering srcRect, including pixels outside it.
// Round the destination origin down to a block boundary.
const size_t srcX = srcRect.x / 4;
const size_t srcY = srcRect.y / 4;
const size_t dstX = xOffset / 4;
const size_t dstY = yOffset / 4;

const size_t blockWidth = (srcRect.x + srcRect.w - 1) / 4 + 1 - srcX;
const size_t blockHeight = (srcRect.y + srcRect.h - 1) / 4 + 1 - srcY;
const size_t dstWidth = (dstImage.width - 1) / 4 + 1;
const size_t dstHeight = (dstImage.height - 1) / 4 + 1;
if (blockWidth > dstWidth - dstX || blockHeight > dstHeight - dstY)
return E_INVALIDARG;

const uint8_t* pEndSrc = srcImage.pixels + srcImage.rowPitch * srcImage.height;
const uint8_t* pEndDest = dstImage.pixels + dstImage.rowPitch * dstImage.height;
const auto validStorage = [bytesPerBlock](const Image& image, size_t x, size_t y, size_t width, size_t height) noexcept
{
const size_t imageBlocks = (image.width - 1) / 4 + 1;
if (!image.rowPitch || imageBlocks > image.rowPitch / bytesPerBlock)
return false;

// Round to bytes
sbpp = (sbpp + 7) / 8;
const size_t rowEnd = (x + width) * bytesPerBlock;
return rowEnd <= image.slicePitch && y + height - 1 <= (image.slicePitch - rowEnd) / image.rowPitch;
};

if (!validStorage(srcImage, srcX, srcY, blockWidth, blockHeight) || !validStorage(dstImage, dstX, dstY, blockWidth, blockHeight))
return E_FAIL;

const uint8_t* pSrc = srcImage.pixels + (srcRect.y * srcImage.rowPitch) + (srcRect.x * sbpp);
const size_t copyBytes = blockWidth * bytesPerBlock;
const uint8_t* pSrc = srcImage.pixels + srcY * srcImage.rowPitch + srcX * bytesPerBlock;
uint8_t* pDest = dstImage.pixels + dstY * dstImage.rowPitch + dstX * bytesPerBlock;
for (size_t row = 0; row < blockHeight; ++row)
{
memcpy(pDest, pSrc, copyBytes);
if (row + 1 < blockHeight)
{
pSrc += srcImage.rowPitch;
pDest += dstImage.rowPitch;
}
}

if (srcImage.format == dstImage.format)
return S_OK;
}
else
{
// Direct copy case (avoid intermediate conversions)
uint8_t* pDest = dstImage.pixels + (yOffset * dstImage.rowPitch) + (xOffset * sbpp);
const size_t copyW = srcRect.w * sbpp;
for (size_t h = 0; h < srcRect.h; ++h)
// Validate rectangle/offset
if (!srcRect.w || !srcRect.h || ((srcRect.x + srcRect.w) > srcImage.width) || ((srcRect.y + srcRect.h) > srcImage.height))
{
if (((pSrc + copyW) > pEndSrc) || (pDest > pEndDest))
return E_FAIL;
return E_INVALIDARG;
}

if (((xOffset + srcRect.w) > dstImage.width) || ((yOffset + srcRect.h) > dstImage.height))
{
return E_INVALIDARG;
}

memcpy(pDest, pSrc, copyW);
// Compute source bytes-per-pixel
size_t sbpp = BitsPerPixel(srcImage.format);
if (!sbpp)
return E_INVALIDARG;

pSrc += srcImage.rowPitch;
pDest += dstImage.rowPitch;
if (sbpp < 8)
{
// We don't support monochrome (DXGI_FORMAT_R1_UNORM)
return HRESULT_E_NOT_SUPPORTED;
}

return S_OK;
}
const uint8_t* pEndSrc = srcImage.pixels + srcImage.rowPitch * srcImage.height;
const uint8_t* pEndDest = dstImage.pixels + dstImage.rowPitch * dstImage.height;

// Compute destination bytes-per-pixel (not the same format as source)
size_t dbpp = BitsPerPixel(dstImage.format);
if (!dbpp)
return E_INVALIDARG;
// Round to bytes
sbpp = (sbpp + 7) / 8;

if (dbpp < 8)
{
// We don't support monochrome (DXGI_FORMAT_R1_UNORM)
return HRESULT_E_NOT_SUPPORTED;
}
const uint8_t* pSrc = srcImage.pixels + (srcRect.y * srcImage.rowPitch) + (srcRect.x * sbpp);

// Round to bytes
dbpp = (dbpp + 7) / 8;
if (srcImage.format == dstImage.format)
{
// Direct copy case (avoid intermediate conversions)
uint8_t* pDest = dstImage.pixels + (yOffset * dstImage.rowPitch) + (xOffset * sbpp);
const size_t copyW = srcRect.w * sbpp;
for (size_t h = 0; h < srcRect.h; ++h)
{
if (((pSrc + copyW) > pEndSrc) || (pDest > pEndDest))
return E_FAIL;

uint8_t* pDest = dstImage.pixels + (yOffset * dstImage.rowPitch) + (xOffset * dbpp);
memcpy(pDest, pSrc, copyW);

auto scanline = make_AlignedArrayXMVECTOR(srcRect.w);
if (!scanline)
return E_OUTOFMEMORY;
pSrc += srcImage.rowPitch;
pDest += dstImage.rowPitch;
}

const size_t copyS = srcRect.w * sbpp;
const size_t copyD = srcRect.w * dbpp;
return S_OK;
}

for (size_t h = 0; h < srcRect.h; ++h)
{
if (((pSrc + copyS) > pEndSrc) || ((pDest + copyD) > pEndDest))
return E_FAIL;
// Compute destination bytes-per-pixel (not the same format as source)
size_t dbpp = BitsPerPixel(dstImage.format);
if (!dbpp)
return E_INVALIDARG;

if (!LoadScanline(scanline.get(), srcRect.w, pSrc, copyS, srcImage.format))
return E_FAIL;
if (dbpp < 8)
{
// We don't support monochrome (DXGI_FORMAT_R1_UNORM)
return HRESULT_E_NOT_SUPPORTED;
}

ConvertScanline(scanline.get(), srcRect.w, dstImage.format, srcImage.format, filter);
// Round to bytes
dbpp = (dbpp + 7) / 8;

if (!StoreScanline(pDest, copyD, dstImage.format, scanline.get(), srcRect.w))
return E_FAIL;
uint8_t* pDest = dstImage.pixels + (yOffset * dstImage.rowPitch) + (xOffset * dbpp);

pSrc += srcImage.rowPitch;
pDest += dstImage.rowPitch;
}
auto scanline = make_AlignedArrayXMVECTOR(srcRect.w);
if (!scanline)
return E_OUTOFMEMORY;

return S_OK;
const size_t copyS = srcRect.w * sbpp;
const size_t copyD = srcRect.w * dbpp;

for (size_t h = 0; h < srcRect.h; ++h)
{
if (((pSrc + copyS) > pEndSrc) || ((pDest + copyD) > pEndDest))
return E_FAIL;

if (!LoadScanline(scanline.get(), srcRect.w, pSrc, copyS, srcImage.format))
return E_FAIL;

ConvertScanline(scanline.get(), srcRect.w, dstImage.format, srcImage.format, filter);

if (!StoreScanline(pDest, copyD, dstImage.format, scanline.get(), srcRect.w))
return E_FAIL;

pSrc += srcImage.rowPitch;
pDest += dstImage.rowPitch;
}

return S_OK;
}
}

//-------------------------------------------------------------------------------------
Expand Down
Loading