Improve PSV0 index sequence collection#8525
Draft
tex3d wants to merge 3 commits into
Draft
Conversation
Use fixed -validator-version 1.8 in ValidationTest::WrongPSVVersion test for the SM 6.8 compilation to avoid having to update the test any time the latest in-development PSV is updated.
- Refactor out of SetPSVSigElement - match end-of-buffer suffix with array prefix to extend buffer instead of rewriting a new sequence. - start with 0 index for RDAT array compatibility (starts with size, index 0 clearly indicates empty array), and to make the most common semantic index of 0 friendlier by making its index always 0. - predicate changes on Val Ver 1.10
New 0 prefix added to semantic indices for compatibility with size-prefixed array format which can now use index zero for zero-length arrays. This index may be unused, which is allowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft because: